Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: skipping hidden sidebar items #1519

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

mvshmakov
Copy link
Contributor

@mvshmakov mvshmakov commented Jul 1, 2020

Fix #1240

Currently, there is no way to implement it efficiently without a wrapper (nkbt/react-collapse#255). There is an ancient pending PR (nkbt/react-collapse#262) that tries to fix it, but it is about the aria-hidden attribute, so the tab navigation would be still broken even (if?) after the merge. I suggest living with this wrapper approach.

@shcheklein shcheklein temporarily deployed to dvc-landing-feature-124-xqrglh July 1, 2020 22:38 Inactive
@shcheklein
Copy link
Member

Nice! thanks @mvshmakov !

@shcheklein shcheklein merged commit f7291d1 into master Jul 1, 2020
@shcheklein shcheklein deleted the feature/1240-skip-hidden-sidebar branch February 28, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[accessibility] nav: skip hidden sidebar items for keyboard navigation
2 participants