-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: shtab completion #1505
blog: shtab completion #1505
Conversation
e8e5945
to
07858bb
Compare
@casperdcl you have to specify an image (picture) in the frontmatter for this to be deployed |
@shcheklein not sure about blog formatting - is this documented somewhere?
|
Hmm https://dvc.org/doc/user-guide/contributing/blog states that the frontmatter picture is optional. I also don't have access permissions for the heroku deployment so can't check the build errors. |
@casperdcl this is a bug to my mind, it should be optional (cc @rogermparent - do we need a ticket for this?) ... could you for not use any image from the previous blogs, just to deploy this :) |
idk since I can't see the logs what I can/can't do to fix this. E.g. are external links allowed? I can commit things blind until it works (probably) :D |
I can take this on soon, in all likelihood optional frontmatter images should be a quick fix. It's probably big enough to warrant an issue, but I'll check it asap whether there is one or not. |
Also do the pictures have to be hosted locally? E.g. I just filled in an xkcd permalink which presumably is reliable enough that we don't have to mirror? The deployment looks like it isn't rendering the external image. |
b7e5033
to
d16ad48
Compare
tags: | ||
- shtab | ||
- Release | ||
- CLI | ||
- Autocomplete | ||
- Tab | ||
- Completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot to review these. Probably too many @shcheklein @casperdcl ? I'd only keep Release
and maybe shtab
because no other tag has any posts. Would maybe add CLI
if it's added retroactively to a few others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to see all current tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same thing: #1657
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel @casperdcl //cc @elleobrien - tags serve two goals - navigation (and we want to keep them sane for this), and SEO (keywords in meta - I haven't checked this, but I hope it still works or we need to fix this). For SEO we want to include things that people will use to search - "Python CLI autocomplete", etc. Thus we need to have a good balance. No need to optimize tags just for the sake of trying to keep them to the minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK in that case all tags here seem relevant, for SEO that is. Though I should say, I think most search engines pretty much ignore suggested meta keywords and extract them from the content instead. But if the meta keywords match the content, then it may be a nice extra.
Article about iterative/shtab.
PR opened primarily to discuss content; not necessarily to merge here (may decide to post elsewhere).
Intention: target general Python devs who may not know about DVC but know the pain of CLI development, thus raising awareness.
preview: https://dvc-landing-shtab-compl-j408nx.herokuapp.com/blog/shtab-completion