Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: shtab completion #1505

Merged
merged 24 commits into from
Jul 27, 2020
Merged

blog: shtab completion #1505

merged 24 commits into from
Jul 27, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jun 28, 2020

Article about iterative/shtab.

PR opened primarily to discuss content; not necessarily to merge here (may decide to post elsewhere).

Intention: target general Python devs who may not know about DVC but know the pain of CLI development, thus raising awareness.

preview: https://dvc-landing-shtab-compl-j408nx.herokuapp.com/blog/shtab-completion

@casperdcl casperdcl self-assigned this Jun 28, 2020
@shcheklein shcheklein had a problem deploying to dvc-landing-shtab-compl-wirzhw June 28, 2020 01:37 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-wirzhw June 28, 2020 01:40 Inactive
@casperdcl casperdcl changed the title blog: shtab-complete blog: shtab completion Jun 28, 2020
@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 28, 2020

Taking inspiration from xkcd; is it worth the time?

shtab would be on the second row, far left (maybe even off grid when considering the number of potential users). It's worth spending days/weeks to sort out but now takes only a minute to fix.

@shcheklein
Copy link
Member

@casperdcl you have to specify an image (picture) in the frontmatter for this to be deployed

@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-ledhqm June 29, 2020 22:38 Inactive
@casperdcl
Copy link
Contributor Author

@shcheklein not sure about blog formatting - is this documented somewhere?

  • picture: is this required? Who creates it? A new picture has to be authored every post?
  • author: is this a github username?
  • commentsUrl: https://discuss.dvc.org/t/some-title/374
    • what does the /t/ mean?
    • what does the /374 mean? Who generates this number?
  • tags: is there a list to choose from?

@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-7mc5qv July 1, 2020 21:24 Inactive
@casperdcl
Copy link
Contributor Author

Hmm https://dvc.org/doc/user-guide/contributing/blog states that the frontmatter picture is optional.

I also don't have access permissions for the heroku deployment so can't check the build errors.

@shcheklein
Copy link
Member

@casperdcl this is a bug to my mind, it should be optional (cc @rogermparent - do we need a ticket for this?) ... could you for not use any image from the previous blogs, just to deploy this :)

@casperdcl
Copy link
Contributor Author

idk since I can't see the logs what I can/can't do to fix this. E.g. are external links allowed? I can commit things blind until it works (probably) :D

@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-yhu2aw July 2, 2020 19:06 Inactive
@rogermparent
Copy link
Contributor

I can take this on soon, in all likelihood optional frontmatter images should be a quick fix. It's probably big enough to warrant an issue, but I'll check it asap whether there is one or not.

@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-yhu2aw July 2, 2020 20:44 Inactive
@casperdcl
Copy link
Contributor Author

casperdcl commented Jul 2, 2020

Also do the pictures have to be hosted locally? E.g. I just filled in an xkcd permalink which presumably is reliable enough that we don't have to mirror? The deployment looks like it isn't rendering the external image.

@shcheklein shcheklein had a problem deploying to dvc-landing-shtab-compl-yhu2aw July 2, 2020 22:04 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 23, 2020 22:06 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 24, 2020 21:22 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 11:58 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 12:35 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 13:19 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 16:50 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 17:16 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 17:17 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 17:18 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 17:57 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 17:58 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 18:06 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-shtab-compl-j408nx July 27, 2020 18:08 Inactive
@shcheklein shcheklein merged commit d7bc015 into master Jul 27, 2020
Comment on lines +19 to +25
tags:
- shtab
- Release
- CLI
- Autocomplete
- Tab
- Completion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to review these. Probably too many @shcheklein @casperdcl ? I'd only keep Release and maybe shtab because no other tag has any posts. Would maybe add CLI if it's added retroactively to a few others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to see all current tags?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same thing: #1657

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel @casperdcl //cc @elleobrien - tags serve two goals - navigation (and we want to keep them sane for this), and SEO (keywords in meta - I haven't checked this, but I hope it still works or we need to fix this). For SEO we want to include things that people will use to search - "Python CLI autocomplete", etc. Thus we need to have a good balance. No need to optimize tags just for the sake of trying to keep them to the minimum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK in that case all tags here seem relevant, for SEO that is. Though I should say, I think most search engines pretty much ignore suggested meta keywords and extract them from the content instead. But if the meta keywords match the content, then it may be a nice extra.

@shcheklein shcheklein deleted the shtab-complete branch February 28, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants