Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd ref: dvc run 1.0 update #1420

Merged
merged 29 commits into from
Jun 22, 2020
Merged

cmd ref: dvc run 1.0 update #1420

merged 29 commits into from
Jun 22, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jun 10, 2020

Stolen some info from #1387

Bring dvc run up to date.

@shcheklein shcheklein temporarily deployed to dvc-landing-1-0-run-a3gf8kncds June 10, 2020 09:34 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-a3gf8kncds June 10, 2020 09:38 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-a3gf8kncds June 10, 2020 09:43 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review June 17, 2020 04:19
@jorgeorpinel

This comment has been minimized.

@shcheklein shcheklein temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 17, 2020 05:07 Inactive
adding simple dvc run usage examples and creating a section about escaping commands
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 17, 2020 17:00 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 17, 2020 17:36 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 17, 2020 17:55 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 17, 2020 18:58 Inactive
autocmd! BufNewFile,BufRead Dvcfile,*.dvc setfiletype yaml
autocmd! BufNewFile,*.dvc setfiletype yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone who uses Vim confirm this though? Maybe @efiop (since I'm about to ping you about something else 😬)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel Just from looking at it, seems like it is broken and should be:

autocmd! BufNewFile,BufRead *.dvc setfiletype yaml

but I would actually keep Dvcfile for now, since it might still be present in older repos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will roll this back for now.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 19, 2020 05:42 Inactive
content/docs/command-reference/run.md Outdated Show resolved Hide resolved
- `--external` - allow outputs that are outside of the DVC repository. See
[Managing External Data](/doc/user-guide/managing-external-data).

- `--file <path>` - specify name of the YAML file this command will generate or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true. --file is ignored for any stages created with -n.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's right but so hmmm what does --file do? This is what the master branch of the core repo outputs:

--file <filename> Specify name of the DVC-file this command will generate.

We don't even have DVC-files anymore!

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also

stages created with -n

-n is always required no? Lil confused rn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like --single-stage is hidden. --single-stage flag is available in dvc run that keeps the same behavior as the 0.X dvc had, regarding single stage files. This -f is a vestige of that. We might reuse -f if we introduce custom named dvc.yaml file someday. But, for dvc.yaml, it's ignored, so, we can just drop it from the documentation altogether.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is a command reference. So, maybe, we should document -f and --single-stage here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I didn't know about --single-stage.

for dvc.yaml, it's ignored, so, we can just drop it from the documentation altogether

Yep, I'll just remove it for now. But it should probably be hidden from the help output in core too? Idk 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skshetry @efiop let's hide in DVC core if --single-stage is hidden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and it's ignored for dvc.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #4084

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 19, 2020 06:12 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 19, 2020 06:35 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 20, 2020 03:12 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 20, 2020 23:30 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 21, 2020 02:07 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 21, 2020 02:08 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 21, 2020 02:58 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-1-0-run-jp6vt2eiw0 June 21, 2020 20:35 Inactive
@shcheklein shcheklein merged commit 4d90ab7 into master Jun 22, 2020
@shcheklein
Copy link
Member

Merged since we are releasing DVC 1.0 tmr. Please let's keep iterating in the new PR

@jorgeorpinel
Copy link
Contributor Author

Continuation PR: #1479

shcheklein pushed a commit that referenced this pull request Jun 24, 2020
* cmd ref: update run usage and options to 1.0a10

* cmd ref: run desc update (1)

* term: remove some instances of Dvcfile (per dvc run updates)

* cmd ref: run desc update (2)

* term: metric files -> metrics and plots files in run desc
per #1420 (review)

* cmd ref: improve run desc. by
adding simple dvc run usage examples and creating a section about escaping commands

* cmd ref: expand "Stage commands" section of run

* cmd ref: make run desc more dvc.yaml-centric and
expand more on stage commands

* cmd ref: run desc and option impros per private feedback

* cmd ref reorg run desc sections and improve cmd examples

* install: roll back Vim plugin change
per #1420 (review)

* user guide: document how wdir works in dirs&files
per #1420 (review)

* cmd ref: expand deps&outs section of run with examples, et al.

* cmd ref: remove incorrect note about param files

* cmd ref: rewrite basic examples of run

* cmd ref: update remaining examples of run ref.

* cmd ref: a few details per private feedback (on run)

* cmd ref: rename params example in run
per #1420 (review)

* Update content/docs/command-reference/run.md

Co-authored-by: Saugat Pachhai <[email protected]>

* cmd ref: move note about deps and params up

* cmd ref: improve note about params in run

* cmd ref: try to slim fown and reord run

* cmd ref: remove run --file option
per #1420 (comment)

* cmd ref: improvements to run per private feedback (1)

* cmd ref: improvements to run per private feedback (2)

* cmd ref: improvements to run per private feedback (3)

* cmd ref: improvements to run per private feedback (4)

* cmd ref: improve examples in run
per private feedback

Co-authored-by: Saugat Pachhai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants