Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed condenscened language from settings #1396
Removed condenscened language from settings #1396
Changes from 2 commits
55c0810
093bf5e
bf8eb46
9c79306
eb642f9
63d113a
bc5e288
f4ac728
7ea6c12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this instance of "simply" counts as condescending. It just means that the operation is not complex. Opening a file is quite simple. Or am I wrong based on whatever source you used to decide these, @kurianbenoy? Please share if so. I could def. be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgeorpinel isn't simply just an adverb in this case, won't it be better to remove this in this context?
For someone who may not be a programmer, maybe opening a file is not quite simple after all. I personally got that impression after reading this article
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK you may be right but I didn't really think we would change anything in the blogs, just the docs section of our website (https://dvc.org/doc)
Let's leave it for now but let @andronovhopf decide on this one. Can you chime in please Elle? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I don't see "simply" as condescending here. You could just replace it with "Just" to be sure though, instead of adding several more words.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I feel let it be like that itself, because - just is also a condescending word instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you went for "You run" — doesn't sound very good. Please use "You can run" for now but this is also in the blog so let's see what @andronovhopf thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, not convinced this is condescending. What's the rationale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you agree with that the wording can be rewritten even more specifically with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you it's not condescending,
I feel instead of just needed, can't we use -> wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though as the article as says:
If it's necessary, what is it trying to say?
With documentation, it's rare for terms like easy to be intentionally condescending. Often times, writers use them to show that something isn't as intimidating as it sounds. If this is the case, think about what the docs are trying to communicate and replace the condescending language with word choices that better represent the intention.
If you're struggling to find alternatives, Jim Fisher has some suggestions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reference @kurianbenoy this makes sense cc @andronovhopf you may find this interesting as well 🙂
But in this case it's neither intentionally nor unintentionally condescending because it's in a conditional sentence so it has a completely different meaning: "if all you need to do is..." and this meaning should be preserved so please roll back or rewrite in the style I just used. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still pending to roll this one back please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Just" is also OK here: Not condescending but descriptive.
But that s was missing indeed, so pls change back to
just downloads
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we find a better word for just in this scenario?
Alex.js warning:
warning
just
may be insensitive, try not to use it just retext-equalityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Alex.js ?
It's not insensitive here. It means "downloads only" but sounds more natural. Please just roll it back 😋 (that one IS insensitive).