Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline comment doc on sidebar.js #1332

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

rogermparent
Copy link
Contributor

Adds the new "style" and "icon" props to the example comment at the top of sidebar.js

Addresses comment from @jorgeorpinel here

@rogermparent rogermparent requested a review from jorgeorpinel May 22, 2020 00:20
@shcheklein shcheklein temporarily deployed to dvc-landing-update-side-1f0r1e May 22, 2020 00:20 Inactive
@calibre-analytics
Copy link

Comparing Update inline comment doc on sidebar.js Snapshot #3 to median since last deploy of DVC.org.

Performance FCP? TTI?
Overall
Median across all pages and test profiles
94
no change
950ms
from 1.1s
3.7s
no change
Chrome Desktop
Chrome • Cable
100
no change
530ms
from 540ms
1.6s
from 1.7s
MotoG4, 3G connection
Motorola Moto G4 • Regular 3G
89
from 80
1.6s
no change
4.9s
from 6.3s

3 pages tested

 Home

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

Value Budget
Lighthouse Performance Score
MotoG4, 3G connection
89
from 74
 Docs

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

No significant changes recorded.

 Blog

Browser previews

Chrome Desktop MotoG4, 3G connection
Chrome Desktop MotoG4, 3G connection

Most significant changes

No significant changes recorded.

Calibre: Site dashboard | View this PR | Edit settings

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha I thought this would be a larger update. Thanks anyway 🙂

@jorgeorpinel jorgeorpinel merged commit bca0a91 into master May 23, 2020
@rogermparent rogermparent deleted the update-sidebar-comment branch May 23, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants