Change how relative fragments are handled. #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Page-relative fragments (specifically, where the whole href starts with '#') are now demoted to plain `a` links in our link wrapper. - The previous behavior that prepended to these links is now removed. - The link wrapper `a` fallback has been expanded upon with comments, and now sets rel specifically on external links that don't already have it.
|
Restyled had some sort of auth error that doesn't look related to the PR itself: |
|
👍 cool stuff @rogermparent . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140 as I understand it, but somebody please do check for possible regressions.
I can successfully do the following behavior:
I can't think of any behavior this change would break, as both the previous and current behavior only apply to fragment links within the same page (with the
href's first character being#), and other fragment links are left alone.One thing to check, though, is the previous behavior of combining existing
relprops withnoopener noreferreron all external links. The behavior I replaced it with only does so if the link is external and doesn't already specify a rel, as I figure covering basic external links is important but if the writer is going out of their way to add a rel then they should assume full control.If we depend on the prior behavior and can't do without it, I can revert this branch to have that functionality while keeping the fix.