Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to replace pretty-quick fully with lint-staged #1252

Closed
wants to merge 1 commit into from

Conversation

jorgeorpinel
Copy link
Contributor

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein temporarily deployed to dvc-landing-lint-no-sta-g801tq May 6, 2020 02:41 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 6, 2020

Just pushed this for future reference. It's not working.

hook. You may also run `yarn format <file>` (format specific file/pattern),
`yarn format-staged` (all staged files), or `yarn format-all` (all `.md`,
`.js` and other source files) before committing changes if needed.
hook. You may also run the formatting [commands](#all-commands) manually.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part I'm going to keep in a regular updates PR thouhg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3c41819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants