Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility] add label to the subscribe from and hide it visually. #1165

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[accessibility] add label to the subscribe from and hide it visually. #1165

merged 1 commit into from
Apr 17, 2020

Conversation

nisarhassan12
Copy link
Contributor

Fixes #1164

@shcheklein
Copy link
Member

@nisarhassan12

If the input is already labeled visually some other way, such as through a magnifying glass icon on a search submit button, it may be acceptable to use aria-label to create an invisible text label for screen readers to read.

would it be eiasier?

@nisarhassan12
Copy link
Contributor Author

@nisarhassan12

If the input is already labeled visually some other way, such as through a magnifying glass icon on a search submit button, it may be acceptable to use aria-label to create an invisible text label for screen readers to read.

would it be eiasier?

@shcheklein Thanks for pointing this out I have updated the Pr accordingly. Indeed this is orders of magnitude easier.

@shcheklein shcheklein merged commit d69a0e5 into iterative:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[accessibility] Subscribe section form the input is missing a label.
2 participants