Ensure icon on sidebar bullets is rotated when link is active #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevgathuku looks awesome! 🙏 can we try to add some minor animation effect into transform? |
|
Sure @shcheklein |
|
Just added the animation @shcheklein |
shcheklein
approved these changes
Apr 16, 2020
|
Perfect, thanks @kevgathuku 🙏 |
|
Glad to help out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1143
Ensure the icon for the sidebar links is rotated for active links
I traced the issue back to the the CSS modules migration #1106
Solution:
Nest the icon rotate CSS rule under the
.activeclass, for it to take effect when the.activeclass is addedBefore (all icons face down)
After (active icons face right)
