Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community gems draft april '20 #1155

Merged
merged 8 commits into from
Apr 22, 2020
Merged

community gems draft april '20 #1155

merged 8 commits into from
Apr 22, 2020

Conversation

elleobrien
Copy link
Contributor

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@elleobrien
Copy link
Contributor Author

Hey @shcheklein, this is meant to publish sometime next week so no rush. There's a really detailed discussion (I think?) on discord here that I didn't include, but I wanted to get your opinion on: https://discordapp.com/channels/485586884165107732/563406153334128681/695408490956718170

I don't fully understand the discussion, so would like your opinion about if it would be a strong addition to this month's post and if so how to repackage it in a Q/A format

@elleobrien elleobrien requested a review from shcheklein April 17, 2020 20:20
@shcheklein
Copy link
Member

@andronovhopf

, so would like your opinion about if it would be a strong addition to this month's post and if so how to repackage it in a Q/A format

that discussion is a dev related, probably pinned it to find it if needed. No need to include it in gems.

Feels a bit less posts/discussions than usual?

@elleobrien
Copy link
Contributor Author

elleobrien commented Apr 17, 2020

@shcheklein got it, i won't include that discussion

as for length- yes, it's a bit shorter. I left some space because i thought we might want to include that Q&A about trees, and it looked like it would be quite long if we did. But since we're not, I'll add a few more questions in the next revision

@shcheklein shcheklein temporarily deployed to dvc-landing-april-gems-7xbsnjg April 20, 2020 23:16 Inactive
look like hashes (because, well, they are). Luckily, DVC handles all the
conversions between the filenames in your local workspace and these hashes. To
get some more intuition about this, check out some of our
[docs](https://dvc.org/doc/command-reference/import#examples) about `dvc import`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we find a better link that explains how data is stored? import/get is a bit strange choice for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this one? I though you were not resolving it for a reason

Copy link
Contributor Author

@elleobrien elleobrien Apr 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be changed. not sure why it isn't showing that code snippet as outdated

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff! some minor final comments and typos

@shcheklein shcheklein temporarily deployed to dvc-landing-april-gems-7xbsnjg April 21, 2020 20:51 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-april-gems-7xbsnjg April 21, 2020 21:15 Inactive
@elleobrien
Copy link
Contributor Author

@shcheklein think this is ready- if you get time today, I'd love to publish

descriptionLong: |
A roundup of technical Q&A's from the DVC community. This month, we discuss
the DVC cache, cloud storage options and concurrency.
picture: ../../static/uploads/images/2020-04-16/DVC_Gems_April_20.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, merge the latest master - I think the way we do URL has changed (simplified)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay just did that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take a look at some other blog posts, please - it's a minor simplification update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you mean with the picture URL. got it! changing now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picture and author probably

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also updated author. although that seems to have thrown a "restyled" error in CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that, restyled fixed an extra space in one of the lines that was introduced

@shcheklein shcheklein had a problem deploying to dvc-landing-april-gems-7xbsnjg April 22, 2020 17:59 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-april-gems-7xbsnjg April 22, 2020 18:06 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-april-gems-7xbsnjg April 22, 2020 18:09 Inactive
@shcheklein shcheklein merged commit 9643100 into master Apr 22, 2020
@elleobrien elleobrien deleted the april_gems branch April 22, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants