add meta tags for SEO #1136
Closed
add meta tags for SEO #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
Apr 10, 2020
| }, | ||
| { | ||
| name: 'twitter:image', | ||
| content: encodeURI(`${siteMeta.siteUrl}${image}`) |
There was a problem hiding this comment.
was encodeURI actually needed? cc @iAdramelk ?
There was a problem hiding this comment.
To be hones I'm not sure. The one who originally added it to the blog was you https://github.com/iterative/blog/commit/3b5c975363fd4f86ef66dd102a2a130759df8fcb . I think then that you where fixing some kind of bug that we have without escaping, but if not, I'm not sure that we need it.
There was a problem hiding this comment.
Good question. I see that I was solving a different problem in the first place - absolute URL vs relative one. Don't remember at all why did I put encodeURI to be honest.
shcheklein
reviewed
Apr 10, 2020
| } | ||
|
|
||
| const BlogPostPage: React.FC<IBlogPostPageProps> = ({ data }) => { | ||
| const BlogPostPage: React.SFC<IBlogPostPageProps> = ({ data }) => { |
shcheklein
reviewed
Apr 10, 2020
| @@ -76,21 +94,13 @@ const DefaultSEO: React.FC<IDefaultSEOProps> = ({ pageInfo }) => { | |||
| meta={meta} | |||
| link={[ | |||
| { | |||
| rel: 'shortcut icon', | |||
| rel: 'icon', | |||
| type: 'image/vnd.microsoft.icon', | |||
There was a problem hiding this comment.
is this type required? legacy?
shcheklein
reviewed
Apr 10, 2020
| type: 'image/vnd.microsoft.icon', | ||
| href: '/favicon.ico' | ||
| }, | ||
| { | ||
| rel: 'icon', |
|
Closing this in favor of #1183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://github.com/iterative/blog/pull/144
On monday I'll see if all the which should be in here, are.
I've removed some stuff from the blog SEO which was repeated from the DefaultSEO component.