Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Blog merging into main website codebase #1091

Merged
merged 65 commits into from
Mar 31, 2020
Merged

[WIP] Blog merging into main website codebase #1091

merged 65 commits into from
Mar 31, 2020

Conversation

pavelgrinchenko
Copy link
Contributor

  • Setup TS
  • Migrate blog's content and components to the main repo

@pavelgrinchenko pavelgrinchenko self-assigned this Mar 24, 2020
@shcheklein shcheklein had a problem deploying to dvc-landing-blog-mergin-pqnakc March 24, 2020 17:22 Failure
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-pqnakc March 24, 2020 17:23 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-p8htyd March 24, 2020 18:16 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-p8htyd March 25, 2020 17:11 Inactive
Copy link
Contributor

@fabiosantoscode fabiosantoscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there!

In general it looks good to me.

You can leave the S3 deployment to me, as I created it originally and can easily migrate it.

Could you make sure the cache-control header is still set to max-age=0 s-maxage=9999? This is for cache revalidation to be mandatory, and be made against CloudFlare and not our poor express server (and after S3 is implemented, to save on S3 outgress costs).

.eslintrc.json Show resolved Hide resolved
.tmp-empty-package/package.json Show resolved Hide resolved
config/postcss/media.js Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.restyled.yaml Outdated Show resolved Hide resolved
src/api/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-p8htyd March 26, 2020 07:27 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-p8htyd March 26, 2020 07:31 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-p8htyd March 26, 2020 08:01 Inactive
@pavelgrinchenko
Copy link
Contributor Author

pavelgrinchenko commented Mar 31, 2020

current master does not have it.

But it has https://take.ms/sRHMm
This PR has font-display: swap which allows to browsers render local fonts first and replace to custom when it will be loaded https://take.ms/R7rOn This behaviour much better, because on the slow connections (mobile networks, etc.) user can't see text for a long time. This flash is showed only one time on first loading.

@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 10:41 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 13:08 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 13:50 Inactive
@fabiosantoscode
Copy link
Contributor

fabiosantoscode commented Mar 31, 2020

This behaviour much better, because on the slow connections (mobile networks, etc.) user can't see text for a long time. This flash is showed only one time on first loading.

👏 👏 and here I was thinking that was a mistake!

Maybe later we can do something where default fonts are only shown when the user (mobile or not) has waited for at least 1 or 2 seconds (until then they see a blank space). That way users on fast wifi don't see the default fonts.

@fabiosantoscode
Copy link
Contributor

fabiosantoscode commented Mar 31, 2020

There is separate PR in the blog repo with redirects iterative/blog#149

Ok, sounds good! Eventually we will want to bring that dyno down, archive the repository and serve everything from here.

@shcheklein
Copy link
Member

This PR has font-display: swap which allows to browsers render local fonts first and replace to custom when it will be loaded https://take.ms/R7rOn This behaviour much better, because on the slow connections (mobile networks, etc.) user can't see text for a long time. This flash is showed only one time on first loading.

Got it @pavelgrinchenko ! thanks for the explanations 🙏

@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 16:18 Inactive
@pavelgrinchenko
Copy link
Contributor Author

Ok, sounds good! Eventually we will want to bring that dyno down, archive the repository and serve everything from here.

It's fine to do this in the PR with migrating deployment to S3 from blog.

@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 16:39 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 16:51 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 17:23 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-blog-mergin-hdexao March 31, 2020 18:31 Inactive
@shcheklein shcheklein merged commit 3467536 into master Mar 31, 2020
@shcheklein shcheklein deleted the blog-merging branch March 31, 2020 23:47
@shcheklein shcheklein restored the blog-merging branch March 31, 2020 23:47
@shcheklein shcheklein deleted the blog-merging branch June 30, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants