-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Blog merging into main website codebase #1091
Conversation
pavelgrinchenko
commented
Mar 24, 2020
- Setup TS
- Migrate blog's content and components to the main repo
1c898df
to
f62fc4c
Compare
…the blog. Merge configs
f62fc4c
to
cc50057
Compare
…. Make all Brandon Grotesque fonts available under one font family name and fix usage of the old one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there!
In general it looks good to me.
You can leave the S3 deployment to me, as I created it originally and can easily migrate it.
Could you make sure the cache-control header is still set to max-age=0 s-maxage=9999
? This is for cache revalidation to be mandatory, and be made against CloudFlare and not our poor express server (and after S3 is implemented, to save on S3 outgress costs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- deduplicate fonts?
- fonts look different old/new (e.g. top menu, Chrome)
- blog styles are different - go one by one, compare carefully (inline code blocks, quotes). Prisma code styles should be taken from DVC.org (colors, not size). Still an issue - https://blog.dvc.org/ml-model-ensembling-with-fast-iterations vs https://dvc-landing-blog-mergin-hdexao.herokuapp.com/blog/ml-model-ensembling-with-fast-iterations (bold + italic, or even just bold does not work? it looked ugly in the previous version, but now does not work at all - need to fix and make not so strong). Image plugin is broken - check one of the images in the text. Image subtitles are different.
- do we cache API calls (Github, Discuss)? (just to make sure)
- clicking on abbreviations in docs (tips) do not work in mobile view
- https://dvc-landing-blog-mergin-fblueu.herokuapp.com/doc/tutorials/versioning - right bar does not work properly?
- features, support - header height id different
- https://dvc-landing-blog-mergin-a6sosq.herokuapp.com/blog/march-20-community-gems - "mins read" differs with prod 5 vs 7
- blog - we don't apply monospace fonts for inline/block code
- anchors when open are hidden under the top menu
- https://dvc-landing-blog-mergin-a6sosq.herokuapp.com/doc/command-reference/version - version must be visible in the left-side bar
- open command reference, version, then install, update or something else - scroll bar jumps, even though they are visible
- when I click get started button in the docs - it reloads the whole website, including fonts, sometimes 404 can be seen during this reload process
- DVC logo in the top menu becomes "inactive" when you click it
- Firefox - font weights are significantly different for blog/docs
But it has https://take.ms/sRHMm |
👏 👏 and here I was thinking that was a mistake! Maybe later we can do something where default fonts are only shown when the user (mobile or not) has waited for at least 1 or 2 seconds (until then they see a blank space). That way users on fast wifi don't see the default fonts. |
Ok, sounds good! Eventually we will want to bring that dyno down, archive the repository and serve everything from here. |
Got it @pavelgrinchenko ! thanks for the explanations 🙏 |
It's fine to do this in the PR with migrating deployment to S3 from blog. |
6bbab89
to
7bf32f7
Compare