-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd-ref: make changes related to update --rev #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor comment
@jorgeorpinel please review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the big delay here and thanks for the changes Saugat! I see a few things weren't addressed from #1007 (review). I would prefer those in but please merge this if you consider it complete.
Just please lmk if you have opinions against those other suggestions so I don't apply them myself in regular updates later without discussing first.
@jorgeorpinel, I have left two suggestions: one related to changing examples (to show about moving between tag to a latest rev in master), and other related to renaming revision to commit. For former one, I don't want to modify current example, but feel free to add one if you think it's important. For later one, commit is not really an accurate word to use here for |
@skshetry I think we're talking about different reviews. There were 4 pending comments in #1007 (review) which don't seem to match with your comments. Anyway, I'm applying them in f8789da for #1110 |
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fix #1062. @jorgeorpinel, not all suggestions have been addressed though. 🙂