docs: protected mode is now enabled by-default #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Mar 16, 2020
efiop
commented
Mar 16, 2020
3 tasks
shcheklein
reviewed
Mar 16, 2020
jorgeorpinel
suggested changes
Mar 16, 2020
Co-Authored-By: Jorge Orpinel <[email protected]>
Co-Authored-By: Jorge Orpinel <[email protected]>
Co-Authored-By: Jorge Orpinel <[email protected]>
|
Will take a fresh look in the morning. Thanks for the reviews! @jorgeorpinel 🙏 |
|
Thank you! Only my comments on public/static/docs/user-guide/large-dataset-optimization.md are pending now, it seems. |
efiop
force-pushed
the
protected-mode-by-default
branch
from
ec32d04 to
14ecc26
Compare
efiop
force-pushed
the
protected-mode-by-default
branch
from
53453ad to
89fa3e4
Compare
|
@jorgeorpinel Addressed all of your comments, please take a look when you'll have time. Thanks! |
Co-Authored-By: Jorge Orpinel <[email protected]>
efiop
force-pushed
the
protected-mode-by-default
branch
from
89fa3e4 to
73447dc
Compare
Comment on lines
42
to
43
| protect against that, DVC makes hard/soft links read-only, forcing the user to | ||
| use `dvc unprotect` before modifying them. Finally, a 4th "linking" alternative |
There was a problem hiding this comment.
Suggested change
| protect against that, DVC makes hard/soft links read-only, forcing the user to | |
| use `dvc unprotect` before modifying them. Finally, a 4th "linking" alternative | |
| protect against that, DVC makes hardlinks and symlinks links read-only, which requires the user to | |
| use `dvc unprotect` before modifying them. | |
| Finally, a 4th "linking" alternative |
Needs rewrap... Let's see if Restyled can fix this ⏳
There was a problem hiding this comment.
Strange. No Restyled difference 🙁
jorgeorpinel
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Done Ruslan! But there's a formatting check failing and Restyled isn't fixing it? See #1058 (comment)
|
@jorgeorpinel Maybe it is not configured right, I haven't looked deeply in our dvc.org setup. Fixed manually. |
shcheklein
reviewed
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterative/dvc#3472
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏