-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd ref: review option defaults and sentence priority per API params #1027
Conversation
jorgeorpinel
commented
Feb 27, 2020
always changed (see `--always-changed` option). This option gives a way to | ||
forcefully execute the `command` anyway. Useful if the command's code is | ||
- `--ignore-build-cache` - forcefully execute the `command` again, even if an | ||
equivalent stage file exists. Useful if the command's code is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would clarify what do we mean by equivalent - same list of same versions of deps, same list of outs, same command. Even if it's part of the different pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"equivalent stage file" is defined exactly in the description already, so I didn't also add it here, to keep the paragraph not-so-long. Should we repeat it anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an "equivalent" (hehe) question for the api docs PR. Should we repeat default behavior in each option paragraph, even when they are explained in the definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. in this case I'm changing the explanation a little to "even if the
same dvc run
command has already been run in this workspace"... See 46eb055
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor comment here https://github.com/iterative/dvc.org/pull/1027/files#r385419275