Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd ref: review option defaults and sentence priority per API params #1027

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

jorgeorpinel
Copy link
Contributor

Extracted from #908 (review)
and #908 (review)

@shcheklein shcheklein temporarily deployed to dvc-landing-cmd-ref-opt-dcqw3y February 27, 2020 06:33 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 27, 2020 07:03
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-cmd-ref-opt-dcqw3y February 27, 2020 07:03 Inactive
always changed (see `--always-changed` option). This option gives a way to
forcefully execute the `command` anyway. Useful if the command's code is
- `--ignore-build-cache` - forcefully execute the `command` again, even if an
equivalent stage file exists. Useful if the command's code is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify what do we mean by equivalent - same list of same versions of deps, same list of outs, same command. Even if it's part of the different pipeline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"equivalent stage file" is defined exactly in the description already, so I didn't also add it here, to keep the paragraph not-so-long. Should we repeat it anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an "equivalent" (hehe) question for the api docs PR. Should we repeat default behavior in each option paragraph, even when they are explained in the definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. in this case I'm changing the explanation a little to "even if the
same dvc run command has already been run in this workspace"... See 46eb055

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants