-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd ref: document dir support for import-url and get-url #841
Comments
thanks! if you don't have time please put a summary of what files/places should be updated. |
@shcheklein Right, good point! I'm mostly worried about command reference for get-url and import-url. The latter one mentions dirs, but doesn't specify that only s3, gs, ssh and local dirs are supported. I've updated the examples in the command help iterative/dvc#2907 |
This comment has been minimized.
This comment has been minimized.
Actually, this one seems pretty straightforward, we can probably do it from scratch ourselves so I'll unassign you. Please just lmk if there are any got-cha's to keep in mind with this new feature. |
@efiop so just HDFS and HTTP are not supported, right? Because both references already say "Download a file or directory from any supported URL" so the change would be actually to say that only certain remotes are supported for dirs. |
@jorgeorpinel Sorry for the delay 🙁 Correct, only those mentioned currently support directories. The rest - doesn't. |
After iterative/dvc#2894 we automatically support s3, gs, local, ssh directories in import-url and get-url.
NOTE: just trying to not forget about this, will try to contribute a PR myself if I can.
The text was updated successfully, but these errors were encountered: