Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd ref: document dir support for import-url and get-url #841

Closed
efiop opened this issue Dec 6, 2019 · 6 comments · Fixed by #931
Closed

cmd ref: document dir support for import-url and get-url #841

efiop opened this issue Dec 6, 2019 · 6 comments · Fixed by #931
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@efiop
Copy link
Contributor

efiop commented Dec 6, 2019

After iterative/dvc#2894 we automatically support s3, gs, local, ssh directories in import-url and get-url.

NOTE: just trying to not forget about this, will try to contribute a PR myself if I can.

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions user-guide labels Dec 6, 2019
@shcheklein
Copy link
Member

@efiop

thanks!

if you don't have time please put a summary of what files/places should be updated.

@efiop
Copy link
Contributor Author

efiop commented Dec 6, 2019

@shcheklein Right, good point! I'm mostly worried about command reference for get-url and import-url. The latter one mentions dirs, but doesn't specify that only s3, gs, ssh and local dirs are supported. I've updated the examples in the command help iterative/dvc#2907

@jorgeorpinel jorgeorpinel changed the title document dir support for import-url and get-url cmd ref: document dir support for import-url and get-url Dec 10, 2019
@jorgeorpinel jorgeorpinel added p1-important Active priorities to deal within next sprints and removed command-reference labels Jan 18, 2020
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor

Actually, this one seems pretty straightforward, we can probably do it from scratch ourselves so I'll unassign you. Please just lmk if there are any got-cha's to keep in mind with this new feature.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 19, 2020

we automatically support s3, gs, local, ssh directories in import-url and get-url

@efiop so just HDFS and HTTP are not supported, right? Because both references already say "Download a file or directory from any supported URL" so the change would be actually to say that only certain remotes are supported for dirs.

UPDATE: See 394e9c8. Feel free to review in #931.

@efiop
Copy link
Contributor Author

efiop commented Jan 30, 2020

@jorgeorpinel Sorry for the delay 🙁 Correct, only those mentioned currently support directories. The rest - doesn't.

@iesahin iesahin added the C: ref Content of /doc/*-reference label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants