Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: document run-cache #1289

Closed
efiop opened this issue May 13, 2020 · 11 comments · Fixed by #2137
Closed

guide: document run-cache #1289

efiop opened this issue May 13, 2020 · 11 comments · Fixed by #2137
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@efiop
Copy link
Contributor

efiop commented May 13, 2020

So far affected commands are run/repro which create and/or use run cache. And push/pull/fetch/potentially status) that transfer (options for that are hidden for now) run cache to/from remote. Run cache is located in .dvc/cache/runs.

@efiop
Copy link
Contributor Author

efiop commented May 13, 2020

Will also need to update run-cache flags in run/repro to explain them through the run-cache concept.

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions p1-important Active priorities to deal within next sprints labels May 13, 2020
@sarthakforwet
Copy link
Contributor

Hey there I wanna work on this issue . Could you assign me this ?

@efiop
Copy link
Contributor Author

efiop commented May 16, 2020

Hi @sarthakforwet ! Thank you! But I don't think it is suitable for a contribution, as it is a WIP feature. Please check out need-help and good-first-issue labels, they should have something more suitable 🙂

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel
Copy link
Contributor

A suggested place to start is to add an "execution and reproduction" section to the dvc run cmd ref. similar to this: https://github.com/iterative/dvc.org/pull/1464/files

efiop added a commit to efiop/dvc that referenced this issue Jun 23, 2020
efiop added a commit that referenced this issue Jun 23, 2020
shcheklein pushed a commit that referenced this issue Jun 23, 2020
efiop added a commit to iterative/dvc that referenced this issue Jun 23, 2020
@jorgeorpinel
Copy link
Contributor

More info that would be good to include for this ticket, from #1448 (comment):

  1. Run-Cache can generate outputs in a suitable condition and that too indirectly (eg: only on run/repro), whereas a lockfile will always provide you with outputs without rerunning.
  2. RunCache can generate lockfile. Even though you have a run-cache, you should still use lockfile because for the outputs.
  3. get/import commands work well only if you have a lockfiile.

(Thanks @skshetry)

@jorgeorpinel
Copy link
Contributor

Hello! So this continues to be a major discrepancy between released DVC and published docs. I know it's being worked on but at least basic mentions of this should exist in the docs for now. Is it still the plan for someone from engineering to submit a draft proposal adding such mentions? Thanks! Cc @efiop @shcheklein

@efiop
Copy link
Contributor Author

efiop commented Jul 22, 2020

@jorgeorpinel Likely no drafts until experiments are here or iterative/dvc#4223 .

@efiop efiop self-assigned this Oct 20, 2020
@jorgeorpinel jorgeorpinel changed the title user-guide: describe what run-cache is and what commands it affects guide: document run-cache Jan 31, 2021
@jorgeorpinel jorgeorpinel mentioned this issue Jan 31, 2021
12 tasks
@jorgeorpinel
Copy link
Contributor

Hi @efiop! I'm finally finishing up some basic docs for this (sort of needed to doc dvc exp). Quick questions:

potentially status

  1. status didn't end up working with the run-cache at all right?

  2. dvc gc doesn't have a way to specifically DO, or DO NOT collect outputs referenced in the run-cache, right?

Thanks

@efiop
Copy link
Contributor Author

efiop commented Feb 2, 2021

  1. Correct, not yet.

  2. Correct.

@jorgeorpinel
Copy link
Contributor

Feel free to reopen or make another issue if/when the run-cache implementation/terminology/etc change, or if more docs should be written. Thanks

@iesahin iesahin added the C: guide Content of /doc/user-guide label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants