Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check git remote exists #126

Merged
merged 10 commits into from
Dec 11, 2023
Merged

Check git remote exists #126

merged 10 commits into from
Dec 11, 2023

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Dec 11, 2023

Fixes iterative/dvclive#753.

Before this PR:

$ python train.py
WARNING:dvc_studio_client:Failed to post to Studio: {"detail":"Permission denied or repo not found, check that origin is a self-hosted gitlab repo"}
WARNING:dvclive:`post_to_studio` `start` failed.

After this PR:

$ python train.py
WARNING:dvc_studio_client:No Git remote. Can't infer Studio repo URL.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dberenbaum !

@shcheklein
Copy link
Member

We should probably still review the error message on the Studio side though ... it's not clear why it was mentioning gitlab self-hosted ... it's a low priority clearly

@dberenbaum
Copy link
Contributor Author

AFAIR Studio tries to validate the URL format, but there wasn't always an easy way to identify all self-hosted gitlab URL formats, so it is a catchall that assumes any URL it can't validate is self-hosted gitlab.

@dberenbaum dberenbaum merged commit 39e7abf into main Dec 11, 2023
14 checks passed
@dberenbaum dberenbaum deleted the no-remote branch December 11, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DVCLive throws a weird warning when origin is not defined
2 participants