Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename initiate_authentication to get_access_token #120

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

amritghimire
Copy link
Contributor

Enhanced token authorization tests for DVC Studio client with improved error checking and exception handling. Introduced get_access_token method to retrieve the Access Token from DVC Server. Added test cases for authorization expiry and error handling. Also added functionality to validate required scopes, which prominently include 'EXPERIMENTS', 'DATASETS', and 'MODELS'. Updated README with relevant changes.

@amritghimire amritghimire added the enhancement New feature or request label Nov 27, 2023
@amritghimire amritghimire self-assigned this Nov 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f041a6b) 100.00% compared to head (7f7bfe7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #120   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          254       292   +38     
  Branches        11        16    +5     
=========================================
+ Hits           254       292   +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enhanced token authorization tests for DVC Studio client with improved error checking and exception handling. Introduced `get_access_token` method to retrieve the Access Token from DVC Server. Added test cases for authorization expiry and error handling. Also added functionality to validate required scopes, which prominently include 'EXPERIMENTS', 'DATASETS', and 'MODELS'. Updated README with relevant changes.
@amritghimire amritghimire merged commit 4563f8b into iterative:main Nov 27, 2023
14 checks passed
@amritghimire amritghimire deleted the rename-method branch November 27, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants