Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: get_file: try linking from storage #351

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

efiop
Copy link
Contributor

@efiop efiop commented May 8, 2023

Still not 100% sold on this approach, but it does make some sense.

Required for iterative/dvc#9385

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 35.71% and project coverage change: -0.10 ⚠️

Comparison is base (125fc29) 58.59% compared to head (37c2af8) 58.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   58.59%   58.50%   -0.10%     
==========================================
  Files          54       54              
  Lines        3502     3511       +9     
  Branches      618      620       +2     
==========================================
+ Hits         2052     2054       +2     
- Misses       1362     1368       +6     
- Partials       88       89       +1     
Impacted Files Coverage Δ
src/dvc_data/fs.py 56.60% <35.71%> (-3.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop marked this pull request as ready for review May 15, 2023 23:40
@efiop efiop merged commit 43acd59 into iterative:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants