Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to secrets for external contributors #574

Merged
merged 3 commits into from
Jun 4, 2021
Merged

Allow access to secrets for external contributors #574

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c35a41
Allow access to secrets for external contributors
0x2b3bfa0 Jun 2, 2021
648efc8
Protect lint job with GitHub Environments
0x2b3bfa0 Jun 2, 2021
ce6bb16
Move authorization to a separate job
0x2b3bfa0 Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,31 @@ on:
- cron: 0 0 * * *
release:
types: [published]
pull_request:
pull_request_target:
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
jobs:
authorize:
environment:
${{ (github.event_name == 'pull_request_target' &&
github.event.pull_request.head.repo.full_name != github.repository) &&
'external' || 'internal' }}
runs-on: ubuntu-latest
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
lint:
needs: authorize
casperdcl marked this conversation as resolved.
Show resolved Hide resolved
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
- uses: actions/setup-node@v2
- run: npm ci
- run: npm run lint
test:
environment:
${{ (github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name != github.repository) &&
'test-external' || 'test-internal' }}
needs: authorize
0x2b3bfa0 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
- uses: actions/setup-node@v2
- uses: actions/setup-python@v2
- run: pip install tensorboard
Expand All @@ -42,6 +50,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
- uses: actions/setup-node@v2
with:
registry-url: https://registry.npmjs.org
Expand Down Expand Up @@ -73,6 +83,7 @@ jobs:
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha || github.ref }}
fetch-depth: 0
- name: Metadata
id: metadata
Expand Down