Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle paths with spaces #1373

Closed

Conversation

Autodidact24
Copy link

Resolving #1369

We can use the encodeURIComponent function to encode any spaces in the node.url property before passing it to the path.resolve function.

This should ensure that image URLs with spaces are resolved correctly and passed to the publish function.

@Autodidact24 Autodidact24 temporarily deployed to external April 9, 2023 11:13 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0
Copy link
Member

Thanks, @Autodidact24! Can you please add a test case for the changes introduced on this pull request? Sorry for the late reply.

@0x2b3bfa0
Copy link
Member

By the way, why does path.resolve need arguments to be URL-encoded? 🤔

@0x2b3bfa0 0x2b3bfa0 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants