-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce subcommands in a backwards-compatible way #1073
Conversation
3826529
to
d0b5e62
Compare
d0b5e62
to
d4a79e3
Compare
d4a79e3
to
44d74c0
Compare
Would |
I was toying with the idea of using |
d6eb1d0
to
da8c820
Compare
🔔 @iterative/cml, ready for a first round of feedback? For now, the only breaking change (as per our last meeting) is that calling The rest of commands are backwards compatible ad nauseam and behave exactly as they did in the past, thanks to a fair amount of Reading the pull request changes is rather cumbersome. Given that tests haven't changed and are still passing,1 I would recommend to Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P.S. we don't need rerun-workflow
backward compat because 'twas never documented/released :P
Gratias @0x2b3bfa0! |
Nihil est, @casperdcl! ⚔️ 🤝 |
Next steps
|
This pull request renames all the commands in a backwards-compatible way, and closes #762.
Functionality remains unchanged, and the only difference is that
cml <balderdash>
can also be called by usingcml <noun> <verb>
as suggested.Dependencies
cml publish
withcml send-comment
#1026 (to avoid rebase hell)Follow-up issues
--publish
&--watch
options tocml check create
#1143--driver
global option for consistency with forge naming #1142cml ci
to follow thecml <noun> <verb>
naming convention #1141cml comment <verb> --rm-watermark
option #1140Outstanding1
unresolved discussionscml ci
with thecml <noun> <verb>
structurecml comment create
and proposal of anupdate
verbFootnotes
As per https://github.com/iterative/cml/pull/1073#issuecomment-1224095678, there might be some threads that were marked as resolved but no action was taken to address they suggestions they include. Feel free to take a look. ↩