Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs on how to use local runners #417

Merged
merged 9 commits into from
Dec 19, 2022
Merged

Improve docs on how to use local runners #417

merged 9 commits into from
Dec 19, 2022

Conversation

michaelgruner
Copy link
Contributor

@michaelgruner michaelgruner commented Dec 8, 2022 •
edited by casperdcl
Loading

No description provided.

@jorgeorpinel
Copy link
Contributor

Thanks @michaelgruner, I see the intention behind your changes, but this is not much clearer yet, I think. Hopefully the team will be able to take it over.

@jorgeorpinel jorgeorpinel added documentation Markdown files enhancement New feature or request labels Dec 8, 2022
@michaelgruner
Copy link
Contributor Author

michaelgruner commented Dec 8, 2022 •
edited
Loading

Oh okay, so the team will take it forward? Let me know if I can help in anything else.

@jorgeorpinel
Copy link
Contributor

Yep. Thanks again for your suggestions and feedback!

@casperdcl casperdcl self-requested a review December 12, 2022 21:34
casperdcl
casperdcl suggested changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @michaelgruner! Some feedback...

content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/self-hosted-runners.md Outdated Show resolved Hide resolved
@jorgeorpinel
Copy link
Contributor

I think you can probably commit your suggestions to get this merged @casperdcl . Up to you

@casperdcl casperdcl self-assigned this Dec 12, 2022
@rogermparent rogermparent mentioned this pull request Dec 12, 2022
Closed
@casperdcl casperdcl merged commit 6dfc933 into iterative:master Dec 19, 2022
@github-actions
Copy link

6dfc933

Link Check Report

There were no links to check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

@jorgeorpinel jorgeorpinel jorgeorpinel left review comments

Assignees

@michaelgruner michaelgruner

@casperdcl casperdcl

Labels
documentation Markdown files enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelgruner @jorgeorpinel @casperdcl