Updated Docs engine #233
Updated Docs engine #233
Conversation
Gatsby Cloud Build Reportcml.dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
src/gatsby/models.js
Outdated
| const imageSourcePaths = require('./models/image-source-paths') | ||
| const github = require('./models/github') | ||
| const pruneCache = require('./models/prune-cache') | ||
|
|
||
| const models = [markdownContent, docs, imageSourcePaths, github, pruneCache] | ||
| const models = [markdownContent, imageSourcePaths, github, pruneCache] |
There was a problem hiding this comment.
I think markdownContent can be removed as well, since nothing aside from docs used it as cml.dev has no blog
There was a problem hiding this comment.
Looking good so far! Awesome that it fixes some existing bugs. There could be more scrubbing done to remove what the theme replaces, but that's not a hugely pressing issue.
I did notice the 404 page doesn't have headers or footers though, which would be annoying in specific situations where the user hits 404 without a page to go back to (outdated links, primarily).
|
Thanks, @rogermparent. |
Opened an issue! (#238) |
|
@julieg18 Thanks for opening the issue. |
Updated docs engine to use reusable package gatsby-theme-iterative.
The latest
[email protected]update iterative/gatsby-theme-iterative#7 does include features requested for cml docs.Fixes #157
Fixes #187
Fixes #238
A Example usage:
https://cmldev-docsengine.gtsb.io/doc/ref/ci
0ca4d40#diff-2285ff562ca51e66d2c3fc4bc92b4a380b47afab4449dfd2c5a07c221f9d9305