Update Gatsby and all other packages #186
Conversation
|
Great @rogermparent. I checked thoroughly, it's running on my machine without any issues, and also the Heroku deployment is also looking good. I think we can proceed further. |
rogermparent
had a problem deploying
to
cml-dev-gatsby-4-upgrad-rifhxk
|
Images were broken before, but I just fixed them and now I think this PR is good to go! Unlike dvc.org, the build doesn't break with existing cache (or maybe it's just so short that a second build doesn't time out) so babysitting won't be as mandatory after merging! |
|
Fixed a minor style issue, code blocks in the title were a bit bigger due to changes in the GitHub Markdown CSS package and the longer ones were line-breaking. before: after: |
There was a problem hiding this comment.
Great job @rogermparent! It looks great! Just one small thing about the docs images and this should be good to merge!
| { | ||
| "files": "*.css", | ||
| "options": { | ||
| "singleQuote": false |
There was a problem hiding this comment.
We should look into adding this to dvc.org!
There was a problem hiding this comment.
dvc.org took a different approach by changing format-staged not to target css files, but giving it this configuration will probably make linting more robust.
| name: 'images', | ||
| path: path.join(__dirname, 'static', 'img') | ||
| } | ||
| }, |
There was a problem hiding this comment.
Glad we're using gatsby-plugin-image for our docs! The images look kind of blurry. If I remember correctly from us fixing this with dvc.org, we need to add quality: 90 to our gatsby-remark-images options.
There was a problem hiding this comment.
I remember the same solution to this problem, but after implementing it I don't notice any improvement. 🤔
|
I'm going to merge this in since it's been effectively approved by everything and it's 99% of the way to parity with master, any remaining issues like the last bit of thumbnail image quality can be addressed in further iterations. |
This PR is primarily meant to upgrade cml.dev to Gatsby 4, but in the process upgrades all other packages to their latest versions and does any changes needed to make builds work after.
It was a surprisingly painless process (not having a blog helps), but it's possible some small things will end up broken so we'll have to check it over before merging.
Fixes #163