-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdown tabs #113
Add markdown tabs #113
Conversation
julieg18
commented
Sep 29, 2021
•
edited
Loading
edited
- I went ahead and converted this pull request to draft since I placed test markdown tabs in docs/index.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation logic is a little hard to follow and could possibly be more elegant, but it looks like it works really well such that I'd say it's more than good enough to let in as a first iteration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me too as a first iteration 🎉 (PS failing link checks were fixed in #110)
Agreed! I attempted to simplify as much as I could but it definitely still looks complex. Hopefully we can improve it at a later date! |
43d01e4
to
584456c
Compare
Could you please clarify - does it render things server side or client side? |
I believe the tabs are rendered server side but input ids are rendered client side. |
So, how much of DOM manipulation is happening on the client side? Before we have been trying hard to keep everything client side (to keep JS to minimum, and to keep page as prepare as it could be) |
Hmmmmm, I think I misunderstood your original question. What did you mean exactly by server side/client side? But as for DOM manipulation, I did my best to use the least amount of JS as I could. We use JS to keep track of the input checked state (so we can connect different sets of inputs) and to generate the IDs for the inputs. The rest is HTML and CSS. |
Okay, no worries. I see that we use HTML to define section and markdown supports it as-is (no need to do any transformations client side markup->HTML). I think it should be fine. Sorry for the confustion. |
@yalozhkin could you please take a look and suggest how to design this? (not a blocker to merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the test data is removed, we can merge this first iteration!
This reverts commit 5310591.