New Auditor: Flag Identity Providers with disabled signature verification #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twwd
previously approved these changes
Oct 1, 2024
malexmave
changed the title
twwd
approved these changes
Oct 1, 2024
twwd
force-pushed
the
feature/oidc-idp-without-signature-checks
branch
from
ee05b3a
to
167a99c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an auditor that checks if a configured Identity Provider does not verify the signature on the tokens of the upstream identity provider. This can lead to dangerous vulnerabilities.
At the moment, it only checks for OIDC and Keycloak-OIDC IDPs. I will have to check which other IDP presents have a similar setting, and adapt the pull request accordingly. Hence, it is a draft.The auditor now supports both SAML and OIDC. Other identity providers do not seem to have an option to disable verification and should thus be safe by default.
Closes #15.