Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMB Features #14672

Closed
wants to merge 85 commits into from
Closed

SMB Features #14672

wants to merge 85 commits into from

Conversation

mbscit
Copy link

@mbscit mbscit commented May 12, 2023

No description provided.

@mbscit mbscit requested a review from a team as a code owner May 12, 2023 21:36
@CLAassistant
Copy link

CLAassistant commented May 12, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ oaehmka
❌ mbscit
You have signed the CLA already but the status is still pending? Let us recheck it.

@dkocher dkocher marked this pull request as draft May 13, 2023 11:30
dkocher
dkocher requested changes May 13, 2023
View reviewed changes
smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SmbExceptionMappingService.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBCopyFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBReadFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBAttributesFinderFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBReadFeature.java Outdated Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBWriteFeature.java Show resolved Hide resolved
@AliveDevil AliveDevil mentioned this pull request May 15, 2023
Closed
@dkocher dkocher linked an issue May 31, 2023 that may be closed by this pull request
Support for Samba (SMB) protocol #5368
Closed
@dkocher dkocher added this to the 9.0 milestone Jun 27, 2023
dkocher
dkocher requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Sqash commits
  • Review comments
  • Resolve TODOs

smb/src/main/java/ch/cyberduck/core/smb/SMBCopyFeature.java Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBCopyFeature.java Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBSession.java Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBProtocol.java Show resolved Hide resolved
smb/src/main/java/ch/cyberduck/core/smb/SMBReadFeature.java Show resolved Hide resolved
dkocher
dkocher requested changes Jul 16, 2023
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Sqash commits
  • Review comments
  • Resolve TODOs

@dkocher dkocher changed the base branch from master to feature/GH-5368 July 16, 2023 09:02
oaehmka and others added 18 commits July 18, 2023 12:33
mbscit and others added 25 commits July 18, 2023 12:36
@mbscit
add improve error-handling in smb directory feature, add tests
3b8581b
@mbscit
add smb move feature test
dd8fb9d
@mbscit
add smb touch feature test
d7bb588
@mbscit
add attributes to smb list service
a8f39ef
@mbscit
add tests for smb read and write feature
32a8158
@mbscit
add missing error handling in smb features
80ecee6
@mbscit
add missing error handling in smb features
86fd381
@oaehmka @mbscit
implement part of PR feedback
f406201
@mbscit
fix smb exception mapper file name
18bdba0
@mbscit
implement part of PR feedback
97c8e8a
@oaehmka @mbscit
fix write feature
bb5e73c
@oaehmka @mbscit
implement PR feedback
19d0339
@oaehmka @mbscit
catch stream.close() error to close file in every case
03fc9b5
@oaehmka @mbscit
dont handle copy recursion
f9eb8ef
@oaehmka @mbscit
close() files cleanup
086d08a
@oaehmka @mbscit
change statefulness to stateless
d638aec
@oaehmka @mbscit
add timestamp feature
59a97a6
@oaehmka @mbscit
fix comment
1f5f3b4
@oaehmka @mbscit
update version number
e3965e6
@oaehmka @mbscit
run tests with github actions
1088388
@oaehmka @mbscit
github actions fix for win and macOS
b88060c
@oaehmka @mbscit
try different option for docker in macOS
686f0c9
@oaehmka @mbscit
test hopefully faster alternative for docker on macOS
9716daf
@oaehmka @mbscit
add testconatiners category + profile to skip them
f1c57e8
@oaehmka @mbscit
disable Testcontainers-Tests for macOS
69f6483
@mbscit mbscit force-pushed the feature/features branch from 3b0c295 to 69f6483 Compare July 18, 2023 13:17
@mbscit
Copy link
Author

mbscit commented Aug 16, 2023 •
edited by dkocher
Loading

We have opened a new PR 1 with all comments resolved and the commits squashed

Footnotes

  1. SMB for Cyberduck #15006 ↩

@mbscit mbscit closed this Aug 16, 2023
@dkocher dkocher removed a link to an issue Aug 19, 2023
Support for Samba (SMB) protocol #5368
Closed
@dkocher dkocher removed this from the 9.0 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbscit @CLAassistant @dkocher @oaehmka