Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower GLSL version requirement #122

Merged
merged 1 commit into from
Aug 13, 2015
Merged

Conversation

Bigpet
Copy link
Contributor

@Bigpet Bigpet commented Aug 13, 2015

I didn't really use any of the newer features anyway.
This should accomodate open source drivers that use older versions of MESA.

Related to #120

@mad-s
Copy link
Contributor

mad-s commented Aug 13, 2015

Please lower the OpenGL version requirement in src/itdelatrisu/opsu/objects/curves/Curve.java:90 to OpenGL 3.0 instead of OpenGL 3.3

I didn't really use any of the newer features anyway.
This should accomodate open source drivers that use older versions of MESA.
@Bigpet
Copy link
Contributor Author

Bigpet commented Aug 13, 2015

@mad-s I guess that would work fine. Technically we would need to check if glsl version "130" is supported too. But I don't know of a driver that supports GL 3.0 but not GLSL 130. (But I mean I did forget that mesa supported GL 3.3 but not GLSL 330 for a while, so just because I can't remember/know doesn't mean that it doesn't exist)

@mad-s
Copy link
Contributor

mad-s commented Aug 13, 2015

According to https://en.wikipedia.org/wiki/OpenGL_Shading_Language#Versions OpenGL 3.3 corresponds to GLSL 3.3 and OpenGL 3.0 corresponds to GLSL 1.3. This is also the reason for 940e9ba, which fixed slider rendering for my GPU.

@Bigpet
Copy link
Contributor Author

Bigpet commented Aug 13, 2015

@mad-s well that means that GLSL 330 and GL 3.3 were released alongside. But if you read the OpenGL specification then you'll realize that those standards are still seperate and to get a conforming OpenGL 3.3 implementation you do not actually need to support GLSL 330. (If this were the case then #120 would be a bug in noveau, but it's not)

edit: nvm, I guess with 3.3+ that is actually a bug
edit2: nah, I read the spec right, the Wiki page was just talking about the version numbers looking similar, not requiring each other

@itdelatrisu
Copy link
Owner

Thanks again for taking care of this. Though, why aren't we checking if GLSL 130 is supported?

@Bigpet
Copy link
Contributor Author

Bigpet commented Aug 13, 2015

@itdelatrisu because I'm lazy 😄 . Also, there's no really good way to poll it other than writing a minimally viable shader program in that version and try to compile and link it. You can only query the highest supported version and I don't think an implementation has to support all previous versions.

itdelatrisu added a commit that referenced this pull request Aug 13, 2015
Lower GLSL version requirement to GLSL 130/OpenGL 3.0
@itdelatrisu itdelatrisu merged commit 988e413 into itdelatrisu:master Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants