-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower GLSL version requirement #122
Conversation
Please lower the OpenGL version requirement in src/itdelatrisu/opsu/objects/curves/Curve.java:90 to OpenGL 3.0 instead of OpenGL 3.3 |
I didn't really use any of the newer features anyway. This should accomodate open source drivers that use older versions of MESA.
@mad-s I guess that would work fine. Technically we would need to check if glsl version "130" is supported too. But I don't know of a driver that supports GL 3.0 but not GLSL 130. (But I mean I did forget that mesa supported GL 3.3 but not GLSL 330 for a while, so just because I can't remember/know doesn't mean that it doesn't exist) |
According to https://en.wikipedia.org/wiki/OpenGL_Shading_Language#Versions OpenGL 3.3 corresponds to GLSL 3.3 and OpenGL 3.0 corresponds to GLSL 1.3. This is also the reason for 940e9ba, which fixed slider rendering for my GPU. |
@mad-s well that means that GLSL 330 and GL 3.3 were released alongside. But if you read the OpenGL specification then you'll realize that those standards are still seperate and to get a conforming OpenGL 3.3 implementation you do not actually need to support GLSL 330. (If this were the case then #120 would be a bug in noveau, but it's not) edit: |
Thanks again for taking care of this. Though, why aren't we checking if GLSL 130 is supported? |
@itdelatrisu because I'm lazy 😄 . Also, there's no really good way to poll it other than writing a minimally viable shader program in that version and try to compile and link it. You can only query the highest supported version and I don't think an implementation has to support all previous versions. |
Lower GLSL version requirement to GLSL 130/OpenGL 3.0
I didn't really use any of the newer features anyway.
This should accomodate open source drivers that use older versions of MESA.
Related to #120