fix exit code on format/label not defined errors

itchyny · Jan 16, 2021 · 3d390af · 3d390af
1 parent 96830fd
commit 3d390af
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/cli/error.go b/cli/error.go
@@ -65,6 +65,9 @@ func (err *compileError) Error() string {
 }
 
 func (err *compileError) ExitCode() int {
+	if err, ok := err.err.(interface{ ExitCode() int }); ok {
+		return err.ExitCode()
+	}
 	return exitCodeCompileErr
 }
 

diff --git a/cli/test.yaml b/cli/test.yaml
@@ -2368,6 +2368,7 @@
   input: '1'
   error: |
     label not defined: "$test"
+  exit_code: 3
 
 - name: invalid break name
   args:
@@ -4503,7 +4504,7 @@
     - '@foo'
   error: |
     format not defined: @foo
-  exit_code: 3
+  exit_code: 5
 
 - name: destructuring alternative operator
   args:

diff --git a/error.go b/error.go
@@ -166,6 +166,10 @@ func (err *formatNotFoundError) Error() string {
 	return fmt.Sprintf("format not defined: %s", err.n)
 }
 
+func (err *formatNotFoundError) ExitCode() int {
+	return 5
+}
+
 type formatCsvTsvRowError struct {
 	typ string
 	v   interface{}
@@ -221,6 +225,10 @@ func (err *breakError) Error() string {
 	return fmt.Sprintf(`label not defined: %q`, err.n)
 }
 
+func (err *breakError) ExitCode() int {
+	return 3
+}
+
 type stringLiteralError struct {
 	s string
 }