Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug su Posizione GPS del post type luogo #339

Closed
2 tasks done
marcogangemideda opened this issue Aug 4, 2023 · 5 comments · Fixed by #355
Closed
2 tasks done

Bug su Posizione GPS del post type luogo #339

marcogangemideda opened this issue Aug 4, 2023 · 5 comments · Fixed by #355
Labels
bug Something isn't working

Comments

@marcogangemideda
Copy link

Prerequisiti

Descrivi il problema

Quando si cerca un indirizzo nel campo "Posizione GPS" di un luogo, rimane un caricamento infinito.
Il problema sembrano essere le librerie di Open Street Map: bisogna togliere il "/" prima del "?" della query string, altrimenti la chiamata all'url risponde 404.

Ad esempio:
https://nominatim.openstreetmap.org/search/?q=via indipendenza bologna&limit=5&format=json&addressdetails=1&json_callback=_l_geocoder_0 --> 404
https://nominatim.openstreetmap.org/search?q=via indipendenza bologna&limit=5&format=json&addressdetails=1&json_callback=_l_geocoder_0 --> 200

Includi link o screenshot

Screenshot 2023-08-04 alle 11 07 33

Su quale sisitema operativo stai riscontrando il problema?

Windows, macOS, Android, iOS, Linux

Su quale browser stai riscontrando il problema?

Qualsiasi

Che versione del tema stai utilizzando?

1.7.1
@marcogangemideda marcogangemideda added the bug Something isn't working label Aug 4, 2023
@fnori77
Copy link

fnori77 commented Aug 9, 2023

Salve, come hai risolto? Grazie.

@fnori77
Copy link

fnori77 commented Aug 9, 2023

Risolto. Il file da modificare è
inc/lib/CMB2-field-Leaflet-Geocoder/assets/js/geocoder.js

@abmcr
Copy link
Contributor

abmcr commented Aug 9, 2023 •
edited
Loading

Qui le specifiche della variazione

#340 (comment)

enrimk added a commit to enrimk/design-comuni-wordpress-theme that referenced this issue Sep 7, 2023
@enrimk
Fix: CMB2 Leaflet Geocoder
767811c 
Fixes italia#339, italia#340
Fix trovato da @abmcr, @fnori77, @marcogangemideda

Fa seguito a un [cambiamento nella API di openstreetmap](osm-search/Nominatim#3134).
@zetareticoli
Copy link
Member

Chiudo perché risolto in #340

@zetareticoli zetareticoli closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2023
@enrimk enrimk mentioned this issue Sep 13, 2023
Merged
2 tasks
@enrimk
Copy link
Contributor

enrimk commented Sep 13, 2023 •
edited
Loading

@zetareticoli
In realtà la commit sopra era una mia patch "privata" che non era stata ancora integrata: adesso ho aperto una PR.

zetareticoli pushed a commit that referenced this issue Oct 16, 2023
@enrimk
Fix: CMB2 Leaflet Geocoder (#355)
799f0ae 
Fixes #339, #340
Fix trovato da @abmcr, @fnori77, @marcogangemideda

Fa seguito a un [cambiamento nella API di openstreetmap](osm-search/Nominatim#3134).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: CMB2 Leaflet Geocoder (OSM API) enrimk/design-comuni-wordpress-theme
5 participants
@zetareticoli @abmcr @enrimk @marcogangemideda @fnori77