Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug with setting doucment-storage-url as basePath in ApiClient #147

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix Bug with setting doucment-storage-url as basePath in ApiClient #147

merged 3 commits into from
Sep 16, 2024

Conversation

boal
Copy link
Contributor

@boal boal commented Sep 11, 2024

Description

Fix Bug with setting doucment-storage-url as basePath in ApiClient

Reference

Issues #146

@boal boal requested a review from a team as a code owner September 11, 2024 07:39
@welcome Welcome
Copy link

welcome bot commented Sep 11, 2024

Greetings from Munich! 🥨
Thank you very much for participating in our project by opening this pull request! ❤
Please check out our contribution guidelines for further information. ℹ
We will review your changes as soon as possible! 👀

@github-actions github-actions bot added Component: Integrations Issues regarding the Integrations Type: Bug The issue is a bug labels Sep 11, 2024
simonhir
simonhir approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir enabled auto-merge (squash) September 16, 2024 08:22
@simonhir simonhir merged commit a9460ee into it-at-m:main Sep 16, 2024
9 checks passed
@welcome Welcome
Copy link

welcome bot commented Sep 16, 2024

It's Munich again! 🥨
Thank you very much for your first successful contribution to our project! ❤
Munich is proud of you! 🎉
Until next time! 👋

drinking beer

@boal boal deleted the bug/146-use-document-storage-url-in-client-lib branch September 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhir simonhir simonhir approved these changes

Assignees
No one assigned
Labels
Component: Integrations Issues regarding the Integrations Type: Bug The issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boal @simonhir