Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/init cosys integration #134

Merged
merged 35 commits into from
Nov 14, 2024
Merged

Feature/init cosys integration #134

merged 35 commits into from
Nov 14, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Sep 4, 2024

Description

Init cosys integration.

Reference

Issues #122

@simonhir simonhir self-assigned this Sep 4, 2024
@simonhir simonhir mentioned this pull request Sep 4, 2024
Closed
5 tasks
@github-actions github-actions bot added Component: Integrations Issues regarding the Integrations Type: Feature The issue is a feature labels Sep 4, 2024
@simonhir simonhir marked this pull request as ready for review September 5, 2024 09:17
@simonhir simonhir requested a review from a team as a code owner September 5, 2024 09:17
@simonhir simonhir added the BREAKING Change may cause existing code to break label Sep 5, 2024
DanielOber
DanielOber requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small changes for now, rest looks fine. For the future, try to not mix topics, because you also made changes to email and s3 integrations. Not a lot, but still better to make them separate, especially in a big mr like this

refarch-integrations/refarch-cosys-integration/refarch-cosys-integration-core/pom.xml Outdated Show resolved Hide resolved
...n-core/src/test/java/de/muenchen/refarch/integration/cosys/adapter/out/s3/S3AdapterTest.java Outdated Show resolved Hide resolved
@simonhir simonhir requested a review from DanielOber September 17, 2024 05:10
@simonhir
Merge branch 'refs/heads/main' into feature/init-cosys-integration
0af9f8c 
# Conflicts:
#	refarch-integrations/refarch-email-integration/refarch-email-integration-rest-example/src/main/resources/application-local.yml
#	refarch-integrations/refarch-s3-integration/README.md
#	refarch-integrations/refarch-s3-integration/refarch-s3-integration-rest/refarch-s3-integration-rest-client-starter/src/main/resources/application-s3-client.yml
@simonhir
♻️ cosys rm oauth config through starter
a8aacf0
@simonhir
Merge branch 'main' into feature/init-cosys-integration
a964375 
# Conflicts:
#	refarch-integrations/README.md
#	refarch-integrations/pom.xml
@simonhir
♻️ cosys example use new oauth2 config style
e34339f
@simonhir
🔖 cosys fix versions after bump
f0dd6a6
@simonhir
🔖 cosys fix versions after bump
9a2c82b
@simonhir
🐛 cosys rm oauth config through starter fix import
cb0df93
@simonhir simonhir requested a review from DanielOber September 19, 2024 12:49
@simonhir simonhir removed the BREAKING Change may cause existing code to break label Sep 19, 2024
DanielOber
DanielOber previously approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@DanielOber DanielOber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir
Copy link
Member Author

Waiting for #208

@simonhir simonhir marked this pull request as draft October 18, 2024 07:28
@simonhir simonhir marked this pull request as ready for review November 12, 2024 09:26
devtobi
devtobi requested changes Nov 14, 2024
View reviewed changes
refarch-integrations/README.md Show resolved Hide resolved
refarch-integrations/README.md Outdated Show resolved Hide resolved
refarch-integrations/refarch-cosys-integration/README.md Outdated Show resolved Hide resolved
refarch-integrations/refarch-cosys-integration/README.md Show resolved Hide resolved
...ations/refarch-cosys-integration/refarch-cosys-integration-client/src/main/api/api-docs.json Show resolved Hide resolved
...n-core/src/test/java/de/muenchen/refarch/integration/cosys/adapter/out/s3/S3AdapterTest.java Show resolved Hide resolved
...ava/de/muenchen/refarch/integration/cosys/application/usecase/CreateDocumentUseCaseTest.java Outdated Show resolved Hide resolved
...ple/src/main/java/de/muenchen/refarch/integration/cosys/example/NoSecurityConfiguration.java Outdated Show resolved Hide resolved
...cosys-integration/refarch-cosys-integration-example/src/main/resources/application-local.yml Outdated Show resolved Hide resolved
...arter/src/main/java/de/muenchen/refarch/integration/cosys/configuration/CosysProperties.java Outdated Show resolved Hide resolved
devtobi
devtobi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir enabled auto-merge (squash) November 14, 2024 12:51
@simonhir simonhir merged commit 7755985 into main Nov 14, 2024
14 checks passed
@simonhir simonhir deleted the feature/init-cosys-integration branch November 14, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

@DanielOber DanielOber DanielOber left review comments

Assignees

@simonhir simonhir

Labels
Component: Integrations Issues regarding the Integrations Type: Feature The issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhir @devtobi @DanielOber