Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 30 adding comment component #36

Merged
merged 20 commits into from
May 2, 2024
Merged

Conversation

langehm
Copy link
Contributor

@langehm langehm commented Apr 22, 2024

Issues #30

@langehm langehm self-assigned this Apr 22, 2024
@langehm langehm linked an issue Apr 22, 2024 that may be closed by this pull request
@langehm langehm changed the title 30 adding comment component ✨ 30 adding comment component Apr 29, 2024
@langehm
Copy link
Contributor Author

langehm commented Apr 29, 2024

If the specialized component with text only is needed, the variant type needs to be extracted from the component into a separate file.

@langehm langehm requested a review from FabianWilms April 29, 2024 10:00
Copy link
Member

@FabianWilms FabianWilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sauber, gefällt mir sehr gut. Habe noch mit einem Commit die fehlenden Font-Definitionen ergänzt - das war mein Fehler.

docs/components/muc-comment.md Outdated Show resolved Hide resolved
docs/components/muc-comment.md Outdated Show resolved Hide resolved
src/components/Comment/MucComment.vue Outdated Show resolved Hide resolved
docs/components/muc-comment.md Outdated Show resolved Hide resolved
@langehm langehm requested a review from FabianWilms May 2, 2024 08:02
@langehm langehm marked this pull request as ready for review May 2, 2024 09:21
@langehm langehm merged commit f298f44 into main May 2, 2024
5 checks passed
Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@FabianWilms FabianWilms deleted the 30-adding-comment-component branch May 7, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding comment component
2 participants