Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 conditionally showing the initials bubble #80 #271

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

langehm
Copy link
Contributor

@langehm langehm commented Oct 9, 2024

Description

  • conditionally showing the blue circle of the initials

Reference

Issues #80

@langehm langehm linked an issue Oct 9, 2024 that may be closed by this pull request
@langehm langehm self-assigned this Oct 9, 2024
@langehm
Copy link
Contributor Author

langehm commented Oct 9, 2024

grafik

@langehm langehm marked this pull request as ready for review October 10, 2024 06:27
FabianWilms
FabianWilms previously approved these changes Oct 11, 2024
Copy link
Member

@FabianWilms FabianWilms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for #246 first, but looks good 👍

@langehm langehm merged commit ab2ea11 into beta Oct 25, 2024
6 checks passed
@langehm langehm deleted the 80-empty-author-shows-empty-initials branch October 25, 2024 13:17
Copy link

🎉 This PR is included in version 1.15.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

v-slot:initials
>{{ computedInitials }}</template
>
<template v-slot:datePrefix>am</template>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats wrong :)

@langehm langehm mentioned this pull request Oct 27, 2024
langehm added a commit that referenced this pull request Nov 7, 2024
* Update dependency @types/node to v20.16.11

* Update dependency typescript to v5.6.3

* Update dependency vite-plugin-dts to v4.2.3

* Update dependency vitest to v2.1.2

* Update dependency @vue/eslint-config-prettier to v10

* ✨ 179 graphical calendar (#214)

* 🍻 added components #179

* 🍻 save #179

* 🍻

* 💄 added some css #179

* changed state to unofficial #179

* added all days of prev, curr and next month #179

* some rework done #179

* 🍻

* added functions for updating mv according to variant #179

* added variant to mucdaytile #179

* added examples #179

* changed type to interface and added comparison methods #179

* 🐛 fixed issues with updating mv and display of selection #179

* linted #179

* changed and added properties #179

* changed examples #179

* changed props to provide/inject #179

* save

* disabled props was falsy set on story #179

* outsourced view of day, month and year view into seperate components #179

* inserted view logic #179

* 💄 inserted animations #179

* 💄 adjusted css styling #179

* added documentation to calendar #179

* added documentation to types #179

* added documentation to month selection #179

* fixed bug in styling and reverted styling into nonscoped block #179

* reverted custom-style.css #179

* 🚚 renamed day view #179

* 🎨 formated redundant const #179

* added documentation to year selection #179

* ♻️ removed unnecessary code #179

* spelling mistake

* added documentation to day selection #179

* added documentation to day-tile #179

* linted and formated #179

* added example #179

* 💄 improve animation code and performance

no more stuttering and smoother

* ♻️ fix linter

* destructured props #179

* ✨ animation can be disabled #179

* 🍺 added first functionality for allowing some dates #179

* 🍻 added components #179

* 🍻 save #179

* 🍻

* 💄 added some css #179

* changed state to unofficial #179

* added all days of prev, curr and next month #179

* some rework done #179

* 🍻

* added functions for updating mv according to variant #179

* added variant to mucdaytile #179

* added examples #179

* changed type to interface and added comparison methods #179

* 🐛 fixed issues with updating mv and display of selection #179

* linted #179

* changed and added properties #179

* changed examples #179

* changed props to provide/inject #179

* save

* disabled props was falsy set on story #179

* outsourced view of day, month and year view into seperate components #179

* inserted view logic #179

* 💄 inserted animations #179

* 💄 adjusted css styling #179

* added documentation to calendar #179

* added documentation to types #179

* added documentation to month selection #179

* fixed bug in styling and reverted styling into nonscoped block #179

* reverted custom-style.css #179

* 🚚 renamed day view #179

* 🎨 formated redundant const #179

* added documentation to year selection #179

* ♻️ removed unnecessary code #179

* spelling mistake

* added documentation to day selection #179

* added documentation to day-tile #179

* linted and formated #179

* added example #179

* 💄 improve animation code and performance

no more stuttering and smoother

* ♻️ fix linter

* destructured props #179

* ✨ animation can be disabled #179

* 🍺 added first functionality for allowing some dates #179

* ✨ added allowDates functionality #179

* 📝 updated documentation #179

* 💄 outsourced stylesheet #179

* 💩

* linted and formated #179

* 💚 pipeline optional dependency

* 💚 try to fix build by updating package-lock.json

* 💚 revert optional dependency

---------

Co-authored-by: jannik.lange <[email protected]>
Co-authored-by: fabian.wilms <[email protected]>

* Update dependency eslint-plugin-vue to v9.29.0 (#275)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* 💣 update to vue 3.5 and switch to  reactive props destructure

* ⬆️ changed to vue 3.5.10 #245

* ♻️ restructured input component for vue 3.5 #245

* ♻️ restructured select component for vue 3.5 #245

* ♻️ Refactored MucBanner to new prop syntax

* ♻️ Refactored MucBanner to new prop syntax, fixed reactivity bug

* ♻️ Refactored MucButton to new prop syntax

* ♻️ Refactored MucCallout to new prop syntax

* ♻️ Refactored MucCard to new prop syntax

* ♻️ Refactored MucComment to new prop syntax

* 🐛 MucComment - Fixed computation for decimal part in rating

* ♻️ Refactored MucCounter to new props destructuring

* ♻️ Refactored MucErrorList to new prop destructuring, added default for title

* 🐛 Fixed reactivity for MucCounter when min/max changes

* ♻️ Refactored MucCommentText to new props destructuring

* ♻️ Refactored modelValue in MucCheckbox

* ♻️ Refactored MucSelectItem to use new prop destructure

* ♻️ Refactored MucTextArea to use new prop destructure

* ♻️ Refactored MucRadioButton to new props destructure

* ♻️ Refactored MucLink to new props destructure

* 🎨 Prettier formatting

* :pencil_2: Update vue version in getting started guide

* 🐛 fix MucInput search story bug

* 💚 make prettier happy

---------

Co-authored-by: jannik.lange <[email protected]>
Co-authored-by: devtobi <[email protected]>
Co-authored-by: Fabian Wilms <[email protected]>
Co-authored-by: fabian.wilms <[email protected]>

* ⬆️ update semantic-release and semantic-release-gitmoji

* ⬆️ update mde version to 1.0.4

* ✨ 276 add mobile mode to counter component (#277)

Co-authored-by: Fabian Wilms <[email protected]>

* #280 drop zone file upload 1px

* #280 drop zone file upload warning icon filled

* #280 format warning text

* #280 fix linter problems

* ✨ 181 stepper component (#279)

* 181: add stepper component

* 181: add mobile and screenreader

* 181: add comments

* 181: format code

* 181: Change example to english

* 181: Add MucCalendar export

* 181: format index.ts

* 🐛 conditionally showing the initials bubble #80 (#271)

* Update dependency @types/node to v20.17.1 (#290)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update storybook monorepo to v8.3.6 (#289)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency vite to v5.4.10 (#288)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency semantic-release to v24.1.3 (#287)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency npm-run-all2 to v6.2.6 (#286)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency eslint-plugin-vue to v9.29.1 (#285)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency vite-plugin-dts to v4.3.0 (#283)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency vue-tsc to v2.1.8 (#291)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency semantic-release to v24.2.0 (#292)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* 🐛 295 bug revert this line (#296)

* ⏪ reverted line #295

* improved example #295

* 298 set absolute size of additional information text

* Update dependency @types/node to v20.17.3 (#301)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency @types/node to v22

* Update dependency eslint-plugin-vue to v9.30.0 (#303)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency vitest to v2.1.4 (#302)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency npm-run-all2 to v7

* Update dependency @vue/eslint-config-prettier to v10.1.0

* 🔥 remove unused npm-run-all

* 💚 fix conflicts

* 💚 fix merge conflicts

* 💚 fix merge conflicts

* ✨ 294 remove margin on icon only button (#297)

* removing margin upon empty slot #294

* added example #294

* Update storybook monorepo to v8.4.2 (#308)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* Update dependency @types/node to v22.9.0 (#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>

* 🐛 fix MucDivider (#282)

* #183 🐛 fix MucDivider

* ♻️ moved css class into the component #183

* ♻️ refactored compoonents to use the muc-divider #183

---------

Co-authored-by: langehm <[email protected]>
Co-authored-by: langehm <[email protected]>

* 💥 update to vue 3.5 and switch to  reactive props destructure and "dist\ subdirectory is no longer needed to import static resources

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: langehm <[email protected]>
Co-authored-by: jannik.lange <[email protected]>
Co-authored-by: devtobi <[email protected]>
Co-authored-by: lehju <[email protected]>
Co-authored-by: Marko Streich <[email protected]>
Co-authored-by: markostreich <[email protected]>
Co-authored-by: langehm <[email protected]>
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty author shows empty initials
2 participants