Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency twig/twig to v3.11.2 [security] #608

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
twig/twig (source) 3.11.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.5.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.7.1 -> 3.11.2 age adoption passing confidence
twig/twig (source) 3.6.1 -> 3.11.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-51754

Description

In a sandbox, an attacker can call __toString() on an object even if the __toString() method is not allowed by the security policy when the object is part of an array or an argument list (arguments to a function or a filter for instance).

Resolution

The sandbox mode now checks the __toString() method call on all objects.

The patch for this issue is available here for the 3.11.x branch, and here for the 3.x branch.

Credits

We would like to thank Jamie Schouten for reporting the issue and Fabien Potencier for providing the fix.

CVE-2024-51755

Description

In a sandbox, and attacker can access attributes of Array-like objects as they were not checked by the security policy.
They are now checked via the property policy and the __isset() method is now called after the security check.
This is a BC break.

Resolution

The sandbox mode now ensures access to array-like's properties is allowed.

The patch for this issue is available here for the 3.11.x branch, and here for the 3.x branch.

Credits

We would like to thank Jamie Schouten for reporting the issue and Nicolas Grekas for providing the fix.

CVE-2024-45411

Description

Under some circumstances, the sandbox security checks are not run which allows user-contributed templates to bypass the sandbox restrictions.

The security issue happens when all these conditions are met:

  • The sandbox is disabled globally;
  • The sandbox is enabled via a sandboxed include() function which references a template name (like included.twig) and not a Template or TemplateWrapper instance;
  • The included template has been loaded before the include() call but in a non-sandbox context (possible as the sandbox has been globally disabled).

Resolution

The patch ensures that the sandbox security checks are always run at runtime.

Credits

We would like to thank Fabien Potencier for reporting and fixing the issue.


Release Notes

twigphp/Twig (twig/twig)

v3.11.2

Compare Source

  • [BC BREAK] Fix a security issue in the sandbox mode allowing an attacker to call attributes on Array-like objects
    They are now checked via the property policy
  • Fix a security issue in the sandbox mode allowing an attacker to be able to call toString()
    under some circumstances on an object even if the __toString() method is not allowed by the security policy

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@ThomasAFink ThomasAFink changed the base branch from main to next October 8, 2024 11:00
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 38a0625 to 41aeae7 Compare October 8, 2024 11:17
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 8, 2024
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] Update dependency twig/twig to v3.11.1 [SECURITY] Oct 8, 2024
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 9, 2024
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] Update dependency twig/twig to v3.11.1 [SECURITY] Oct 9, 2024
@renovate renovate bot changed the title Update dependency twig/twig to v3.11.1 [SECURITY] fix(deps): update dependency twig/twig to v3.11.1 [security] Oct 11, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch 2 times, most recently from 5af2561 to 0450016 Compare November 6, 2024 22:02
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] fix(deps): update dependency twig/twig to v3.11.2 [security] Nov 6, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 0450016 to 5110866 Compare November 12, 2024 20:42
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.2 [security] fix(deps): update dependency twig/twig to v3.11.1 [security] Nov 12, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 5110866 to f62e609 Compare November 12, 2024 20:57
@renovate renovate bot changed the title fix(deps): update dependency twig/twig to v3.11.1 [security] fix(deps): update dependency twig/twig to v3.11.2 [security] Nov 12, 2024
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from f62e609 to 8c0fa4e Compare November 12, 2024 22:50
@renovate renovate bot force-pushed the renovate/packagist-twig-twig-vulnerability branch from 8c0fa4e to ef29172 Compare December 11, 2024 08:35
Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants