Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(#768): migrate address integration to spring boot 3 #937

Conversation

StephanStrehlerCGI
Copy link
Contributor

@StephanStrehlerCGI StephanStrehlerCGI commented Nov 7, 2023

Description

Short description or comments

Reference

Issues: #768

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@zambrovski
Copy link
Contributor

Let's use digiwf-logging for all logging tracing stuff...

#768: upgrade wiremock test server version
…ons_address_integration

# Conflicts:
#	digiwf-libs/digiwf-spring-security/digiwf-spring-security-starter/src/main/java/de/muenchen/oss/digiwf/spring/security/postprocessor/DefaultPropertiesEnvironmentPostProcessor.java
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@cdff66b). Click here to learn what that means.

Files Patch % Lines
...f/gateway/configuration/SecurityConfiguration.java 88.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #937   +/-   ##
======================================
  Coverage       ?   31.17%           
  Complexity     ?     1209           
======================================
  Files          ?      632           
  Lines          ?    10149           
  Branches       ?      611           
======================================
  Hits           ?     3164           
  Misses         ?     6831           
  Partials       ?      154           
Flag Coverage Δ
unittests 31.17% <98.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephanStrehlerCGI StephanStrehlerCGI marked this pull request as ready for review November 10, 2023 10:33
@lmoesle lmoesle changed the title #768: WIP migrate address integration to spring boot 3 feature(#768): migrate address integration to spring boot 3 Nov 13, 2023
Copy link
Contributor

@lmoesle lmoesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 passt

…-in-integrations_address_integration' into feature/#768-upgrade-spring-boot-in-integrations_address_integration
…ons_address_integration

# Conflicts:
#	digiwf-integrations/digiwf-s3-integration/digiwf-s3-integration-core/pom.xml
#	digiwf-process/digiwf-process-api/src/main/java/de/muenchen/oss/digiwf/process/api/config/api/dto/ConfigEntryTO.java
@StephanStrehlerCGI StephanStrehlerCGI merged commit 8d7933c into dev Nov 16, 2023
5 checks passed
@StephanStrehlerCGI StephanStrehlerCGI deleted the feature/#768-upgrade-spring-boot-in-integrations_address_integration branch November 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants