Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1457 pruefung gesamtgroesse dateien #1810

Merged
merged 21 commits into from
Jul 4, 2024

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented Jul 1, 2024

Description

Reference

Issues: #1457

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external
    and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change -
    See Dependency Graph
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 54 lines in your changes missing coverage. Please review.

Project coverage is 46.81%. Comparing base (652acf3) to head (305c924).

Files Patch % Lines
...s3/integration/adapter/in/rest/FileController.java 0.00% 15 Missing ⚠️
...f/ticket/integration/adapter/out/s3/S3Adapter.java 65.78% 12 Missing and 1 partial ⚠️
...wf/s3/integration/adapter/out/s3/S3Repository.java 66.66% 8 Missing ⚠️
...iwf/s3/integration/client/service/FileService.java 79.31% 3 Missing and 3 partials ⚠️
.../integration/adapter/in/rest/FolderController.java 0.00% 6 Missing ⚠️
...giwf/dms/integration/adapter/out/s3/S3Adapter.java 88.37% 4 Missing and 1 partial ⚠️
...integration/application/FileOperationsUseCase.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1810      +/-   ##
============================================
+ Coverage     46.29%   46.81%   +0.51%     
- Complexity     1024     1061      +37     
============================================
  Files           503      503              
  Lines          7752     7902     +150     
  Branches        466      474       +8     
============================================
+ Hits           3589     3699     +110     
- Misses         4009     4046      +37     
- Partials        154      157       +3     
Flag Coverage Δ
unittests 46.81% <72.72%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich self-assigned this Jul 1, 2024
@markostreich markostreich marked this pull request as ready for review July 1, 2024 16:20
@lehju lehju self-requested a review July 2, 2024 05:46
@markostreich markostreich enabled auto-merge (squash) July 4, 2024 13:38
@markostreich markostreich merged commit 32e2d96 into dev Jul 4, 2024
15 checks passed
@markostreich markostreich deleted the feature/1457-pruefung-gesamtgroesse-dateien branch July 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prüfung der Gesamtgröße bei der Verarbeitung von Dateien in Integrationen
2 participants