Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dms integration return content coos #1760

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Jun 12, 2024

Description

Return content coos on create document.

Reference

Issues: #1704

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph -> bpm-modeler!87

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.61%. Comparing base (bbe03db) to head (d2a67cc).
Report is 2 commits behind head on dev.

Files Patch % Lines
...igiwf/dms/integration/domain/DocumentResponse.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1760      +/-   ##
============================================
+ Coverage     44.51%   44.61%   +0.09%     
- Complexity     1707     1711       +4     
============================================
  Files           658      659       +1     
  Lines          9620     9639      +19     
  Branches        484      484              
============================================
+ Hits           4282     4300      +18     
- Misses         5153     5154       +1     
  Partials        185      185              
Flag Coverage Δ
unittests 44.61% <96.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir marked this pull request as ready for review June 12, 2024 07:02
@simonhir simonhir requested a review from lehju June 12, 2024 08:03
@simonhir simonhir merged commit 94de869 into dev Jun 13, 2024
15 checks passed
@simonhir simonhir deleted the feature/dms-integration-return-content-coos branch June 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants