Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cypress refactor and example usertask #1731

Merged
merged 28 commits into from
Jun 3, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented May 29, 2024

Description

Refactor digiwf-cypress and init example usertask test.

Reference

Issues: #1396

Screenshots (If UI changed)

Check-List

@simonhir simonhir self-assigned this May 29, 2024
@github-actions github-actions bot added digiwf-cypress cypress frontend tests feature labels May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (fa6a9ab) to head (f46d21c).
Report is 14 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1731   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir force-pushed the feature/cypress-refactor-and-example-usertask branch 2 times, most recently from 7a93a10 to 25ad701 Compare May 29, 2024 11:09
@simonhir simonhir force-pushed the feature/cypress-refactor-and-example-usertask branch from 030ec90 to c9274ae Compare May 29, 2024 12:44
@simonhir simonhir marked this pull request as ready for review May 31, 2024 06:29
@darenegade darenegade self-requested a review May 31, 2024 06:30
@simonhir
Copy link
Member Author

One problem still is that when updating the dependencies the check license compliance / compliance action fails with a very unclear error message.

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An sich passt der Code. War nicht sicher, inwieweit wir hier schon überall auf bessere identifier umsteigen wollten.

Ansonsten würde ich es aber gerne noch zum Laufen bekommen, damit die Anleitung passt. Können wir Montag machen

Der Rest passt aber

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt

@simonhir simonhir merged commit 6f7c1ae into dev Jun 3, 2024
14 checks passed
@simonhir simonhir deleted the feature/cypress-refactor-and-example-usertask branch June 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants