Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1706 Fix the property mismatch in Annotation CronJobConfiguration of s3-integration-starter #1707

Conversation

boal
Copy link
Contributor

@boal boal commented May 22, 2024

Description

Fix the property mismatch in Annotation CronJobConfiguration of s3-integration-starter

Reference

Issues: #1706

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (fccc8ee) to head (3dba93b).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1707   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boal

Danke für den Beitrag, aber so können wir es nicht akzeptieren, da es ein Schritt rückwärts wäre. Die Domain io.muenchendigital gehört nicht zu LHM und kann daher nicht verwendet werden. Stattdessen sollten die anderen Properties angepasst werden

@darenegade
Copy link
Member

Aufgrund von #1706 (comment) werden wir das über einen anderen PR lösen müssen.

@darenegade darenegade closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants