Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimize migrate sensitive var filter #1661

Merged
merged 12 commits into from
May 8, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented May 6, 2024

Description

Migrate sensitive variable filter from gitlab to digiwf-core and make it configurable.

Reference

Issues: #1659

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Documentations external and internal are completed
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained -> digiwf-ops!440

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (3916094) to head (770b698).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1661   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich self-requested a review May 7, 2024 09:45
Copy link
Contributor

@markostreich markostreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit e8bbd46 into dev May 8, 2024
14 of 15 checks passed
@simonhir simonhir deleted the feature/optimize-migrate-sensitive-var-filter branch May 8, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants