Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fehler unique identifier #1648

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented Apr 30, 2024

Description

Feld uuid in DwfMultiFileInput war bei der Umstellung zu Composition-API noch defekt.

Reference

Issues: #1644

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
    - [ ] JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@markostreich markostreich self-assigned this Apr 30, 2024
@github-actions github-actions bot added digiwf-apps bug Something isn't working labels Apr 30, 2024
Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt

@markostreich markostreich marked this pull request as ready for review April 30, 2024 14:55
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.69%. Comparing base (ea639c0) to head (9547f22).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1648      +/-   ##
============================================
+ Coverage     44.67%   44.69%   +0.01%     
- Complexity     1696     1697       +1     
============================================
  Files           651      651              
  Lines          9605     9610       +5     
  Branches        475      476       +1     
============================================
+ Hits           4291     4295       +4     
  Misses         5134     5134              
- Partials        180      181       +1     
Flag Coverage Δ
unittests 44.69% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich merged commit 783e561 into dev Apr 30, 2024
14 of 15 checks passed
@markostreich markostreich deleted the fix/1644-uuid-multi-file-input branch April 30, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants