Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Auto Create Topics #1630

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

darenegade
Copy link
Member

@darenegade darenegade commented Apr 24, 2024

Description

Dont create topics automatically

Reference

Issues: #1415

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change - See Dependency Graph)
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@darenegade darenegade self-assigned this Apr 24, 2024
@darenegade darenegade marked this pull request as ready for review April 24, 2024 07:48
@darenegade darenegade enabled auto-merge (squash) April 24, 2024 07:52
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.67%. Comparing base (cc667e2) to head (863e49d).
Report is 20 commits behind head on dev.

❗ Current head 863e49d differs from pull request most recent head 8ebcb01. Consider uploading reports for the commit 8ebcb01 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1630   +/-   ##
=========================================
  Coverage     44.67%   44.67%           
  Complexity     1696     1696           
=========================================
  Files           651      651           
  Lines          9605     9605           
  Branches        475      475           
=========================================
  Hits           4291     4291           
  Misses         5134     5134           
  Partials        180      180           
Flag Coverage Δ
unittests 44.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darenegade darenegade merged commit 19dad37 into dev Apr 24, 2024
12 checks passed
@darenegade darenegade deleted the feat/1415-no-auto-create-topics branch April 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants