Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camunda prometheus task metrics also include suspended #1595

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Apr 18, 2024

Description

Camunda prometheus metrics rm active from task metrics to match cockpit ui.

Check-List

  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

@simonhir simonhir self-assigned this Apr 18, 2024
@github-actions github-actions bot added digiwf-libs bug Something isn't working labels Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 44.68%. Comparing base (68840a0) to head (8126353).
Report is 1 commits behind head on dev.

Files Patch % Lines
...digiwf/camunda/prometheus/TaskMetricsProvider.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1595   +/-   ##
=========================================
  Coverage     44.68%   44.68%           
  Complexity     1696     1696           
=========================================
  Files           651      651           
  Lines          9603     9603           
  Branches        475      475           
=========================================
  Hits           4291     4291           
  Misses         5132     5132           
  Partials        180      180           
Flag Coverage Δ
unittests 44.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir enabled auto-merge (squash) April 18, 2024 10:44
Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passt, nach direkter Diskussion mit @simonhir

@simonhir simonhir merged commit 34344e2 into dev Apr 18, 2024
13 of 16 checks passed
@simonhir simonhir deleted the bugfix/fix-engine-metrics-tasks branch April 18, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants