Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1401 enhance process config with incident notification addresses #1545

Merged
merged 10 commits into from
Apr 12, 2024

Conversation

markostreich
Copy link
Contributor

@markostreich markostreich commented Apr 4, 2024

Description

Reference

Issues: #1401

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@markostreich markostreich self-assigned this Apr 4, 2024
@markostreich markostreich linked an issue Apr 4, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 67.50000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 44.08%. Comparing base (6693a23) to head (5d1eda4).
Report is 19 commits behind head on dev.

Files Patch % Lines
...giwf/engine/incidents/IncidentNotifierHandler.java 75.00% 3 Missing and 5 partials ⚠️
...gine/incidents/IncidentNotificationProperties.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1545      +/-   ##
============================================
+ Coverage     43.62%   44.08%   +0.45%     
- Complexity     1658     1673      +15     
============================================
  Files           648      650       +2     
  Lines          9593     9616      +23     
  Branches        469      470       +1     
============================================
+ Hits           4185     4239      +54     
+ Misses         5237     5201      -36     
- Partials        171      176       +5     
Flag Coverage Δ
unittests 44.08% <67.50%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the docs label Apr 8, 2024
@markostreich markostreich marked this pull request as ready for review April 8, 2024 07:21
@markostreich markostreich removed the docs label Apr 8, 2024
@simonhir simonhir self-requested a review April 8, 2024 07:48
@markostreich markostreich changed the title 1401 enhance process config with incident notification adresses 1401 enhance process config with incident notification addresses Apr 8, 2024
@github-actions github-actions bot added the docs label Apr 8, 2024
markostreich and others added 2 commits April 11, 2024 14:30
Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM würde aber die Properties wie unten beschrieben noch korrigieren

@markostreich markostreich enabled auto-merge (squash) April 12, 2024 10:02
@markostreich markostreich merged commit b98047a into dev Apr 12, 2024
14 of 15 checks passed
@markostreich markostreich deleted the feature/1401-incident-notification-to-prozess-owner branch April 12, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incident-Notification to Prozess-Owner
2 participants