Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#920: add reader support for file input #1520

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Conversation

StephanStrehlerCGI
Copy link
Contributor

@StephanStrehlerCGI StephanStrehlerCGI commented Mar 28, 2024

Description

Reference

Issues: #920

Screenshots (If UI changed)

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.62%. Comparing base (eb03b78) to head (f6c57ba).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1520   +/-   ##
=========================================
  Coverage     43.62%   43.62%           
  Complexity     1658     1658           
=========================================
  Files           648      648           
  Lines          9593     9593           
  Branches        469      469           
=========================================
  Hits           4185     4185           
  Misses         5237     5237           
  Partials        171      171           
Flag Coverage Δ
unittests 43.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markostreich markostreich requested a review from lehju April 2, 2024 08:05
# Conflicts:
#	digiwf-apps/packages/apps/digiwf-tasklist/package-lock.json
#	digiwf-apps/packages/components/digiwf-dms-input/package-lock.json
#	digiwf-apps/packages/components/digiwf-multi-file-input/package-lock.json
@lehju lehju merged commit f9b3c4a into dev Apr 9, 2024
15 of 20 checks passed
@lehju lehju deleted the feature/#920-multifile-reader branch April 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants