Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(#1217): usertask notifications #1218

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

lmoesle
Copy link
Contributor

@lmoesle lmoesle commented Jan 16, 2024

Description

Short description or comments

Reference

Issues: closes #1217

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-engine bug Something isn't working labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (139bede) 38.50% compared to head (3a4a499) 38.47%.

❗ Current head 3a4a499 differs from pull request most recent head d35a1dd. Consider uploading reports for the commit d35a1dd to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                     @@
##             release/2024-january    #1218      +/-   ##
==========================================================
- Coverage                   38.50%   38.47%   -0.04%     
+ Complexity                   1308     1307       -1     
==========================================================
  Files                         598      598              
  Lines                        8671     8668       -3     
  Branches                      424      423       -1     
==========================================================
- Hits                         3339     3335       -4     
- Misses                       5194     5195       +1     
  Partials                      138      138              
Flag Coverage Δ
unittests 38.47% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmoesle lmoesle merged commit 37f1e90 into release/2024-january Jan 16, 2024
4 checks passed
@lmoesle lmoesle deleted the bugfix/#1217-task-notifications branch January 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants