Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix / timezone for follow-up date #1203

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

zambrovski
Copy link
Contributor

@zambrovski zambrovski commented Jan 11, 2024

Description

  • fixes timezone by setting follow-up dates.
  • don't truncate hours offset
  • add test to specify correct date conversion

Reference

Issues: closes #446

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No Branch waste left
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained

@github-actions github-actions bot added digiwf-task bug Something isn't working labels Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4392f7c) 38.50% compared to head (32d59ce) 38.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1203   +/-   ##
=========================================
  Coverage     38.50%   38.50%           
  Complexity     1308     1308           
=========================================
  Files           598      598           
  Lines          8671     8671           
  Branches        424      424           
=========================================
  Hits           3339     3339           
  Misses         5194     5194           
  Partials        138      138           
Flag Coverage Δ
unittests 38.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@StephanStrehlerCGI StephanStrehlerCGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht gut aus. ich teste es gleichmal manuell

@StephanStrehlerCGI
Copy link
Contributor

manuell nachgetestet. sieht gut aus!

@zambrovski zambrovski merged commit 8df6a4c into dev Jan 11, 2024
9 checks passed
@zambrovski zambrovski deleted the bugfix/446__fix_timzone_on_follow_up branch January 11, 2024 13:57
lmoesle pushed a commit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task-Service: Follow Up Timezone Fehler
2 participants